Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #318

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #318

merged 1 commit into from
Nov 4, 2022

Conversation

dimitar-kostadinov
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind cleanup
/platform vsphere

What this PR does / why we need it:
Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations

Which issue(s) this PR fixes:
Fixes #kubernetes/kubernetes#79548

Special notes for your reviewer:
spec.priorityClassName is set according to PriorityClasses in Gardener Clusters

Release note:

scheduler.alpha.kubernetes.io/critical-pod annotation is removed as pod priority (spec.priorityClassName) is used instead to mark pods as critical

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2022
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 4, 2022
@briantopping briantopping marked this pull request as ready for review November 4, 2022 17:46
@briantopping briantopping requested review from a team as code owners November 4, 2022 17:46
briantopping
briantopping approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@briantopping briantopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@briantopping briantopping merged commit 646f352 into gardener:main Nov 4, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 4, 2022
@dimitar-kostadinov dimitar-kostadinov deleted the remove-critical-pod-annotation branch November 14, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantopping briantopping briantopping approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/vsphere VMware vSphere platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimitar-kostadinov @briantopping @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot