Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Critical Pod Annotation #79548

Closed
bsalamat opened this issue Jun 28, 2019 · 3 comments · Fixed by #79554, #80342 or #102129
Closed

Remove Critical Pod Annotation #79548

bsalamat opened this issue Jun 28, 2019 · 3 comments · Fixed by #79554, #80342 or #102129
Assignees
@draveness
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Milestone
v1.16

Comments

@bsalamat
Copy link
Member

bsalamat commented Jun 28, 2019 •
edited

Critical Pod Annotation is an experimental feature that lets Kubernetes control plane know about a pod being a critical pod by adding a specific annotation to the pod. This was added in 1.5 when K8s didn't have pod priority. Pod priority allows us to mark pods as critical with our first-class API. As a result, this feature was deprecated in 1.13. We can now remove the feature from our code base.

/sig scheduling
/sig node
@bsalamat bsalamat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 28, 2019
@bsalamat bsalamat added this to the v1.16 milestone Jun 28, 2019
@draveness
Copy link
Contributor

/assign

@draveness draveness mentioned this issue Jun 29, 2019
Merged
@draveness
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@draveness: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 18, 2019
This was referenced Jul 18, 2019
Merged
Merged
@SataQiu SataQiu mentioned this issue May 19, 2021
Merged
This was referenced Nov 3, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
openstack-mirroring pushed a commit to openstack/openstack-helm-infra that referenced this issue Jun 7, 2023
@liupeng0518
replace scheduler.alpha.kubernetes.io/critical-pod with priorityClass…
0053fc5 
…Name

this feature was deprecated in 1.13. Now it`s not work.[1]

"scheduler.alpha.kubernetes.io/critical-pod annotation is removed. Pod priority (spec.priorityClassName) should be used instead to mark pods as critical. Action required!"[2]

[1]kubernetes/kubernetes#79548
[2]kubernetes/kubernetes#79554

Change-Id: I5913030634fe3f53b11ddb9bbe40d665f45a1254
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Jun 7, 2023
@liupeng0518 @openstack-gerrit
Update git submodules
90301df 
* Update openstack-helm-infra from branch 'master'
  to 0053fc5737304e598dc2372413544a739c65e8b3
  - replace scheduler.alpha.kubernetes.io/critical-pod with priorityClassName
    
    this feature was deprecated in 1.13. Now it`s not work.[1]
    
    "scheduler.alpha.kubernetes.io/critical-pod annotation is removed. Pod priority (spec.priorityClassName) should be used instead to mark pods as critical. Action required!"[2]
    
    [1]kubernetes/kubernetes#79548
    [2]kubernetes/kubernetes#79554
    
    Change-Id: I5913030634fe3f53b11ddb9bbe40d665f45a1254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draveness draveness

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
v1.16
3 participants
@draveness @bsalamat @k8s-ci-robot