Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added prow jobs for dependency-watchdog #435

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Oct 12, 2022

/kind enhancement

What this PR does / why we need it:
This PR adds prow jobs for unit tests and image builds of dependency-watchdog repository.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2022
@rfranzke
Copy link
Member

@oliver-goetz Do we want/are we ready to let further repositories be managed via Prow? IIRC, last time we decided to only manage g/g and a few extensions until we have more maintainers. Is this still up-to-date?

@unmarshall
Copy link
Contributor Author

/invite @oliver-goetz

Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some basic labels and plugins required for prow to work for a repository.
Please check what Dimitar did in plugins.yaml, labels.yaml and ci-infra-periodics.yaml for enabling gardener-extension-shoot-oidc-service see PR #157

@oliver-goetz
Copy link
Member

@oliver-goetz Do we want/are we ready to let further repositories be managed via Prow? IIRC, last time we decided to only manage g/g and a few extensions until we have more maintainers. Is this still up-to-date?

There is only very maintenance effort for us when there are only a couple of prow jobs sharing the same pattern we use for gardener/gardener. That's the same setup as gardener-extension-shoot-oidc-service Dimitar added a while ago.

There will be more effort when other repositories would like to enable the full prow functionality including tide and other github integrations. For this we might need more maintainers. Maybe Dimitar, Madhav or other people from Bangalore team could help, when we come to this point.

@oliver-goetz
Copy link
Member

/kind enhancement

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 12, 2022
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2022
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many labels and plugins for the "testing only" scenario in prow.

config/prow/labels.yaml Show resolved Hide resolved
config/prow/plugins.yaml Show resolved Hide resolved
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 14, 2022
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@gardener-prow
Copy link

gardener-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@gardener-prow gardener-prow bot merged commit 821653d into gardener:master Oct 14, 2022
@gardener-prow
Copy link

gardener-prow bot commented Oct 14, 2022

@unmarshall: Updated the following 2 configmaps:

  • job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key ci-infra-periodics.yaml using file config/jobs/ci-infra/ci-infra-periodics.yaml
    • key dependency-watchdog-build-dev-images.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-build-dev-images.yaml
    • key dependency-watchdog-check-vulnerabilities.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-check-vulnerabilities.yaml
    • key dependency-watchdog-test-builds.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-test-builds.yaml
    • key dependency-watchdog-unit-tests.yaml using file config/jobs/dependency-watchdog/dependency-watchdog-unit-tests.yaml
  • plugins configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
This PR adds prow jobs for unit tests and image builds of dependency-watchdog repository.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants