Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added prow job for KinD based druid e2e #553

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Added prow job for KinD based druid e2e #553

merged 3 commits into from
Jun 14, 2023

Conversation

abdasgupta
Copy link
Contributor

/kind enhancement
What this PR does / why we need it:
This PR enables to run KinD based Druid e2e tests through prow jobs

Which issue(s) this PR fixes:
Fixes #
gardener/etcd-druid#465
Special notes for your reviewer:

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jan 18, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
@oliver-goetz
Copy link
Member

Prow is not enabled for etcd-druid repository yet.
You have to add some basic configuration settings similar to what Madhav did for dependency-watchdog repository in PR #435 in order to make it work.

@abdasgupta
Copy link
Contributor Author

I will address your suggestion in this PR. We are currently trying with something that enables us to use local storage instead of remote storage. In that case, we may not need to create secrets for AWS credentials in prow cluster at all. If our effort is successful, I will update this PR with correct configs. Please, wait till then. Thanks

@abdasgupta abdasgupta mentioned this pull request Jan 30, 2023
Closed
@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2023
@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close

/lifecycle rotten

@gardener-prow gardener-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2023
@abdasgupta
Copy link
Contributor Author

/remove-lifecycle rotten

@gardener-prow gardener-prow bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 16, 2023
@abdasgupta
Copy link
Contributor Author

/remove-lifecycle stale

@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2023
@abdasgupta
Copy link
Contributor Author

@oliver-goetz Would you pls hv a look on the PR. I updated

@gardener-ci-robot
Copy link
Collaborator

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
acumino
acumino reviewed Jun 5, 2023
View reviewed changes
config/jobs/etcd-druid/druid-e2e-kind.yaml Outdated Show resolved Hide resolved
config/jobs/etcd-druid/druid-e2e-kind.yaml Outdated Show resolved Hide resolved
config/jobs/etcd-druid/druid-e2e-kind.yaml Outdated Show resolved Hide resolved
config/jobs/etcd-druid/druid-e2e-kind.yaml Outdated Show resolved Hide resolved
acumino
acumino suggested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than few formatting.
/lgtm

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2023
@acumino
Copy link
Member

acumino commented Jun 5, 2023

/hold

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@gardener-prow gardener-prow bot requested a review from acumino June 5, 2023 10:18
@oliver-goetz
Copy link
Member

Nothing to add to @acumino comments 👍

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2023
@acumino
Copy link
Member

acumino commented Jun 8, 2023

/ping @abdasgupta
Can you please address the review?

acumino
acumino reviewed Jun 9, 2023
View reviewed changes
config/jobs/etcd-druid/druid-e2e-kind.yaml Outdated
Comment on lines 64 to 65
cpu: 12
memory: 18Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, other than that lgtm.
Have you tested the resource consumption for this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested specifically. But that amount of resource is enough for the e2e tests. Basically, we run the tests inside a KIND cluster running inside a container.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is not to allocate unnecessarily a lot of resources to prevent resource wastage.
/cc @oliver-goetz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to @acumino. We have nodes with 16 CPUs, so the etcd-druid test would consume an entire node.
Usually, we require 12 CPUs for our big e2e tests in gardener/gardener where 15 shoots are created in parallel. The smaller tests require 6 CPUs.
Your description sound like the etcd-druid test rather fits into the small test category, so let's start with 6 CPUs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let me come back to this after I check with the resources..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seshachalam-yv helped me to verify that the druid e2e tests run even with 6cpu and 8Gi mem. So I changed the PR to use that much resources only.

acumino
acumino reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/approve

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acumino
Copy link
Member

acumino commented Jun 14, 2023

/cc @oliver-goetz for lgtm

@gardener-prow
Copy link

gardener-prow bot commented Jun 14, 2023

@acumino: GitHub didn't allow me to request PR reviews from the following users: for, lgtm.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @oliver-goetz for lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliver-goetz
Copy link
Member

thanks, let's see how it works 😄
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jun 14, 2023

LGTM label has been added.

Git tree hash: d792e44a66a2ffbed2791b297184cd13eb93ee3e

@gardener-prow gardener-prow bot merged commit 3c457a5 into gardener:master Jun 14, 2023
1 check passed
@gardener-prow
Copy link

gardener-prow bot commented Jun 14, 2023

@abdasgupta: Updated the following 2 configmaps:

  • plugins configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml
  • job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:
    • key ci-infra-periodics.yaml using file config/jobs/ci-infra/ci-infra-periodics.yaml
    • key druid-e2e-kind.yaml using file config/jobs/etcd-druid/druid-e2e-kind.yaml

In response to this:

/kind enhancement
What this PR does / why we need it:
This PR enables to run KinD based Druid e2e tests through prow jobs

Which issue(s) this PR fixes:
Fixes #
gardener/etcd-druid#465
Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliver-goetz oliver-goetz mentioned this pull request Jun 14, 2023
Merged
@abdasgupta abdasgupta deleted the e2e branch June 15, 2023 03:46
@shreyas-s-rao shreyas-s-rao mentioned this pull request Jun 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino requested changes

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@acumino acumino

@oliver-goetz oliver-goetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abdasgupta @oliver-goetz @gardener-ci-robot @acumino