Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up copies for openstack-cloud-controller-manager and cinder-csi-plugin #649

Merged

Conversation

ialidzhikov
Copy link
Member

/kind cleanup

What this PR does / why we need it:
gardener/gardener-extension-provider-openstack#593 proposes to eliminate the Gardener GCR copies for openstack-cloud-controller-manager:{v1.24.6,v1.25.5,v1.26.2} and cinder-csi-plugin:{v1.24.5,v1.25.3,v1.26.0}.

Which issue(s) this PR fixes:
See above

Special notes for your reviewer:
N/A

@gardener-prow
Copy link

gardener-prow bot commented Mar 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Something that is not needed anymore and can be cleaned up labels Mar 24, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2023
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@gardener-prow
Copy link

gardener-prow bot commented Mar 24, 2023

LGTM label has been added.

Git tree hash: 2be56bf53c7999fc213aca022da5b706e1ef648c

@ialidzhikov ialidzhikov marked this pull request as ready for review March 26, 2023 09:00
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2023
@oliver-goetz
Copy link
Member

/approve

@gardener-prow
Copy link

gardener-prow bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@gardener-prow gardener-prow bot merged commit 608d82b into gardener:master Mar 27, 2023
1 check passed
@ialidzhikov ialidzhikov deleted the cleanup/provider-openstack-tags branch March 27, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants