Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to upstream GCR images for openstack-cloud-controller-manager and cinder-csi-plugin #593

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 24, 2023

How to categorize this PR?

/area networking
/area open-source
/kind enhancement
/platform openstack

What this PR does / why we need it:
With kubernetes/cloud-provider-openstack#1540 openstack-cloud-controller-manager and cinder-csi-plugin images are pushed to GCR. See https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-provider-os/images.yaml
Hence, we do no longer need to maintain our copies for 1.24, 1.25, 1.26.

Which issue(s) this PR fixes:
See above.

Special notes for your reviewer:
N/A

Release note:

provider-openstack does no longer use Gardener GCR copies for `openstack-cloud-controller-manager` and `cinder-csi-plugin` in versions 1.24, 1.25 and 1.26. Instead, the upstream GCR container images are used (`registry.k8s.io/provider-os/openstack-cloud-controller-manager` and `registry.k8s.io/provider-os/cinder-csi-plugin`).
The following images are updated:
- registry.k8s.io/provider-os/cinder-csi-plugin: v1.24.5 -> v1.24.6 (for Kubernetes 1.24 Shoots)
- registry.k8s.io/provider-os/cinder-csi-plugin: v1.25.3 -> v1.25.5 (for Kubernetes 1.25 Shoots)
- registry.k8s.io/provider-os/cinder-csi-plugin: v1.26.0 -> v1.26.2 (for Kubernetes 1.26 Shoots)

…nager` and `cinder-csi-plugin`

With kubernetes/cloud-provider-openstack#1540 `openstack-cloud-controller-manager` and `cinder-csi-plugin` images are pushed to GCR. Hence, we do no longer need to maintain our copies.
@gardener-robot gardener-robot added area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2023
@ialidzhikov
Copy link
Member Author

/assign @timebertt @robinschneider

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2023
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@timebertt Command /lgtm is not available to you but only to a Maintainer, Member.

Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 24, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2023
@MartinWeindel MartinWeindel marked this pull request as ready for review March 24, 2023 12:33
@MartinWeindel MartinWeindel merged commit cc6b169 into gardener:master Mar 24, 2023
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 24, 2023
@MartinWeindel MartinWeindel mentioned this pull request Mar 24, 2023
@ialidzhikov ialidzhikov deleted the enh/switch-back-to-upstream-gcr branch March 26, 2023 08:10
@ialidzhikov
Copy link
Member Author

I now deleted the images

  • eu.gcr.io/gardener-project/3rd/k8scloudprovider/openstack-cloud-controller-manager:{v1.24.6,v1.25.5,v1.26.2}
  • eu.gcr.io/gardener-project/3rd/k8scloudprovider/cinder-csi-plugin:{v1.24.5,v1.25.3,v1.26.0}

as these images were added only for few hours to provider-openstack@master and then this PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants