Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shoots list and Journal comments not refreshing after recovering from lost websocket connection #104

Closed
petersutter opened this issue Jun 12, 2018 · 2 comments
Closed

Shoots list and Journal comments not refreshing after recovering from lost websocket connection #104

petersutter opened this issue Jun 12, 2018 · 2 comments
Assignees
@petersutter
Labels
kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution

Comments

@petersutter
Copy link
Contributor

petersutter commented Jun 12, 2018 •
edited

When the websocket connection is lost and afterwards the connection is established again, the dashboard does not automatically subscribe to shoots and journal comments, causing the shoot list / journal to show old data
@petersutter petersutter added the kind/bug Bug label Jun 12, 2018
@petersutter petersutter self-assigned this Jun 12, 2018
@petersutter petersutter added the kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution label Jun 12, 2018
@petersutter
Copy link
Contributor Author

regression introduced with commit d3a6629#diff-cbb57a93db20c8f6f047d1f828235696

@petersutter petersutter changed the title Shoots list is not refreshing after recovering from lost websocket connection Shoots list and Journal comments not refreshing after recovering from lost websocket connection Jun 12, 2018
@petersutter
Copy link
Contributor Author

petersutter commented Jun 12, 2018 •
edited

cc @mandelsoft @rfranzke

holgerkoser added a commit that referenced this issue Jun 26, 2018
@holgerkoser
Merge branch 'master' of git://github.com/gardener/dashboard
21bc9df 
* 'master' of git://github.com/gardener/dashboard:
  #92 fix transparent toolbar in ShootEditor
  frontend: updated marked to 0.4.0 and oidc-client to 1.5.1
  Now using SelfSubjectAccessReview for isAdmin check. Instead of reading the cluster role binding garden-administrators and checking if the user is included in the subjects, we now make use of the SelfSubjectAccessReview. -> If someone is allowed to delete shoots in all namespaces he is considered to be an administrator
  Preparation for #42: Include quota information when fetching infrastructure secrets
  Prepare next dev cycle 1.15.0-dev
  Release 1.14.0
  Update frontend & backend to version 1.14.0 [skip ci]
  Popover bottom placement On the shoot details page the Popover for the Status and Readiness chips were behind the tabs bar. Had to place the popover at the bottom of the chips (poor man's solution).
  Shoot Details page / yaml not refreshing #106 - Refactored Emitter.js - Now we are subscribing a single shoot when accessing the shoot details page - fixed also a bug with journals: The comments would not be shown when the websocket (browser) has no connection to the dashboard backend and meanwhile an already closed journal is reopened and afterwards the websocket connection is established again. It would only show the issue description.
  [fix] Shoot details not cleared when shoot is deleted
  Show Shoot status and readiness on detail page #90 switched Monitoring card with Kube-Cluster Access card
  now using `confirmation.garden.sapcloud.io/deletion=true` annotation when deleting shoots - fixed unit test
  Restart dex pod when configmap changes
  now using `confirmation.garden.sapcloud.io/deletion=true` annotation when deleting shoots, but still having the old behavior for backwards compatibility see also gardener/gardener@cce0385#diff-63756e0de99297a92eabe6585558346b
  fixed/improved backend error handling in middleware
  Prometheus metrics
  Show Shoot status and readiness on detail page #90
  fixed #104 Shoots list and Journal comments not refreshing after recovering from lost websocket connection

Resolved Conflicts:
*	backend/test/support/nocks/k8s.js
*	frontend/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petersutter petersutter

Labels
kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petersutter