Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-Termination Information/Warning #42

Closed
6 of 8 tasks
vlerenc opened this issue Mar 22, 2018 · 2 comments
Closed
6 of 8 tasks

Self-Termination Information/Warning #42

vlerenc opened this issue Mar 22, 2018 · 2 comments
Assignees
@grolu
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension

Comments

@vlerenc
Copy link
Member

vlerenc commented Mar 22, 2018 •
edited by grolu

Stories

  • As user I want to know when my trial cluster is terminating, so that I know for how long I can use it.

Motivation

Clusters that are created with trial secrets will usually self-terminate (default is 7 days, but it depends). The user should know of this.

Acceptance Criteria

  • When the cluster is created, please let him know that it will self-terminate and when (depends on the secret that is used)
  • When the cluster is shown in list or details view, please let him know when it will self-terminate
    • When the cluster is near its end of life (last 24h) make this even more visible (color, boldness, whatever seems appropriate and fits the technology and UI design)

Definition of Done

  • Knowledge is distributed: Have you spread your knowledge in pair programming/code review?
  • Unit Tests are provided: Have you written automated unit tests or added manual NGPTT tickets?
  • Integration Tests are provided: Have you written automated integration tests?
  • Minimum API exposure: If you have added public API, was it really necessary/is it minimal?
  • Operations guide: Have you updated the operations guide?
@vlerenc vlerenc added the kind/enhancement Enhancement, improvement, extension label Mar 22, 2018
@mliepold
Copy link

mliepold commented Jun 1, 2018

Annotation at the Shoot resource:
"shoot.garden.sapcloud.io/expirationTimestamp"

@petersutter
Copy link
Contributor

see also gardener/gardener#81

@grolu grolu self-assigned this Jun 18, 2018
grolu added a commit that referenced this issue Jun 19, 2018
@grolu
Preparation for #42: Include quota information when fetching infrastr…
af99fcb 
…ucture secrets
holgerkoser added a commit that referenced this issue Jun 26, 2018
@holgerkoser
Merge branch 'master' of git://github.com/gardener/dashboard
21bc9df 
* 'master' of git://github.com/gardener/dashboard:
  #92 fix transparent toolbar in ShootEditor
  frontend: updated marked to 0.4.0 and oidc-client to 1.5.1
  Now using SelfSubjectAccessReview for isAdmin check. Instead of reading the cluster role binding garden-administrators and checking if the user is included in the subjects, we now make use of the SelfSubjectAccessReview. -> If someone is allowed to delete shoots in all namespaces he is considered to be an administrator
  Preparation for #42: Include quota information when fetching infrastructure secrets
  Prepare next dev cycle 1.15.0-dev
  Release 1.14.0
  Update frontend & backend to version 1.14.0 [skip ci]
  Popover bottom placement On the shoot details page the Popover for the Status and Readiness chips were behind the tabs bar. Had to place the popover at the bottom of the chips (poor man's solution).
  Shoot Details page / yaml not refreshing #106 - Refactored Emitter.js - Now we are subscribing a single shoot when accessing the shoot details page - fixed also a bug with journals: The comments would not be shown when the websocket (browser) has no connection to the dashboard backend and meanwhile an already closed journal is reopened and afterwards the websocket connection is established again. It would only show the issue description.
  [fix] Shoot details not cleared when shoot is deleted
  Show Shoot status and readiness on detail page #90 switched Monitoring card with Kube-Cluster Access card
  now using `confirmation.garden.sapcloud.io/deletion=true` annotation when deleting shoots - fixed unit test
  Restart dex pod when configmap changes
  now using `confirmation.garden.sapcloud.io/deletion=true` annotation when deleting shoots, but still having the old behavior for backwards compatibility see also gardener/gardener@cce0385#diff-63756e0de99297a92eabe6585558346b
  fixed/improved backend error handling in middleware
  Prometheus metrics
  Show Shoot status and readiness on detail page #90
  fixed #104 Shoots list and Journal comments not refreshing after recovering from lost websocket connection

Resolved Conflicts:
*	backend/test/support/nocks/k8s.js
*	frontend/package-lock.json
@vlerenc vlerenc added component/dashboard Gardener Dashboard and removed component/dashboard Gardener Dashboard labels Jun 27, 2018
grolu added a commit that referenced this issue Jun 28, 2018
@grolu
[Feature] Show Cluster Self Termination Warning #42
750b229 
- Show warning when selecting secret with clusterLifeTimeDays quota on cluster creation dialog
- Show information about remaining cluster lifetime on shoot list and detail page
grolu added a commit that referenced this issue Jun 29, 2018
@grolu
Finish Implementation of Cluster Self Termination Warning #42
5680c9e
@grolu grolu mentioned this issue Jun 29, 2018
Merged
petersutter added a commit that referenced this issue Jul 2, 2018
@petersutter
Merge pull request #119 from gardener/self_termination_warning
4358a5f 
Self-Termination Information/Warning #42
holgerkoser added a commit that referenced this issue Jul 3, 2018
@holgerkoser
Merge branch 'master' into octokit
e4eda06 
* master:
  [Fix] Removed mr-right class to make maintenance window help texts use full window width #67
  Prepare next dev cycle 1.16.0-dev
  Release 1.15.0
  Finish Implementation of Cluster Self Termination Warning #42
  [Feature] Show Cluster Self Termination Warning #42 - Show warning when selecting secret with clusterLifeTimeDays quota on cluster creation dialog - Show information about remaining cluster lifetime on shoot list and detail page
@grolu grolu closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grolu grolu

Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vlerenc @petersutter @grolu @mliepold