Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*hidden* feature of cluster upgrade #167

Closed
freegroup opened this issue Aug 14, 2018 · 6 comments
Closed

*hidden* feature of cluster upgrade #167

freegroup opened this issue Aug 14, 2018 · 6 comments
Assignees
Labels
kind/discussion Discussion (enaging others in deciding about multiple options)

Comments

@freegroup
Copy link

freegroup commented Aug 14, 2018

The basic setting of the overview does not include the version of the Kubernetes Cluster. It is therefore not possible for the user to see if an Update of the Cluster is possible or not. Furthermore, one of the strengths of the Gardener is that it can migrate a Cluster. However, this core feature is very, very hidden and not obvious to the end user.

Default overview

bildschirmfoto 2018-08-14 um 14 15 18

Customized view with the version attribute

bildschirmfoto 2018-08-14 um 14 20 52

For me it is not clear what the meaning of an outlined or filled version label is and why one of them has a drop shadow and the other one not

@grolu
Copy link
Contributor

grolu commented Aug 14, 2018

We could enable this by default, however we must not make too many columns visible by default to not break usability on smaller screen sizes. Moreover, the user always sees the version / upgrade button on shoot details page. For the filled / not filled button state I recommend reading the tooltip: Filled -highlighted- buttons indicate that there is a patch available. As patches should always be applied as soon as possible, this is highlighted. If a user does not uncheck the automatic updates during maintenance option, he will not see this state in most cases.

@grolu
Copy link
Contributor

grolu commented Aug 14, 2018

@vlerenc @holgerkoser @petersutter we should discuss which columns should be in enabled by default in our next UI sync.

@grolu grolu added the kind/discussion Discussion (enaging others in deciding about multiple options) label Aug 14, 2018
@freegroup
Copy link
Author

freegroup commented Aug 14, 2018

and the semantic of the drop shadow for the filled button? :-)

I have an outline button which offers an update if I click on it AND I have a filled button with offers an update if I click on it. In booth cases an update is available for different button styles. For me, there is no semantic relation between style and action.

@vlerenc
Copy link
Member

vlerenc commented Aug 14, 2018

Well, default columns is a big question. People want to focus on different things and that's why its configurable.

We have name, infrastructure, createdBy, createdAt, purpose, status, version, readiness, and actions (omitting the admin features).

If you need space, drop createdBy and createdAt. Why? Because it is not in our "educational interest". In said interest is that the users know and care for the infrastructure and region they are, what the purpose is (because it affects SLAs), status and version anyhow.

If you need more space, drop the readiness. Why? Because it's included/reflected in the status.

If you need more space, drop the actions. Why? Because it's in the details, except for the deletion that a.) is planned to be offered there anyhow (as per our sync before the last one) and it's a rare action.

That leaves name, infrastructure, purpose, status and version as bare minimum, which doesn't take that much space. As said, I would drop the actions only as last resort and generally, people may learn of the configurability rather late. Meaning, if we take it out, some of our users may never know, that we can show than the default columns.

That at least is my try to tackle the question rationally. As you know, I try to "recluse myself" from plain taste questions, because everybody has a different taste. From a rational perspective, I hope this makes some sense for the majority, at least.

@grolu
Copy link
Contributor

grolu commented Aug 14, 2018

Actually, the readiness is not reflected in the cluster status. We often see clusters with issues that have a green checkmark, as the status only reflects the last operation.

@vlerenc
Copy link
Member

vlerenc commented Aug 14, 2018

You are absolutely right, thank you for reminding me. However, at one point in time, we need to have a "more inclusive" status indicator. Not only because we plan to extend the list of conditions, which means, it won't be a sustainable strategy to show chips if the number of them grows. Now we have 3, we plan to include a fourth one and I can't tell right now, what the Gardener extensibility epic will bring. We must however expect a more fine-granular status representation with many more (not grouped/aggregated) conditions from different sources/controllers that at best can be aggregated into a single and overall health indicator. Future-wise, this may or may not be helpful for the Dashboard as any work on the chips may not pay off long term. The (single) status indicator is the thing will prevail, this way or another.

@grolu grolu self-assigned this Aug 22, 2018
This was referenced Aug 22, 2018
grolu added a commit that referenced this issue Sep 19, 2018
* Improved Status Icon
- Show checkmark instead of tractor during reconciliation (if no error occurred)
- Fixed alignments and sizes of different icons
- Added a width to the parent div & centered icon inside

* Updates to ShootVersion Dialog #171
- Removed shadow of button
- Always show update dialog with warning color
- Show version upgrade path in dropdown selection

* Made columns version and purpose visible by default as discussed in #167

* Removed update button margin to not expand row height when displaying version button

* removed darken-2 for action buttons

* Added information about local time to maintenance window configuration

* bumped node version to 10.10

* Some fixes as discussed

* Removed moment (replaced by moment-timezone)

* Fixes as discussed

* Reset timezone in create cluster reset
Fixed timezone change

* Changes as discussed

* Changed texts on update cluster screen (again)

* final text change on update cluster dialog
@grolu grolu closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Discussion (enaging others in deciding about multiple options)
Projects
None yet
Development

No branches or pull requests

3 participants