Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui improvements #178

Merged
merged 16 commits into from
Sep 19, 2018
Merged

Ui improvements #178

merged 16 commits into from
Sep 19, 2018

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Aug 24, 2018 •
edited by petersutter

What this PR does / why we need it:
This PR bundles some small UI improvements

Which issue(s) this PR fixes:
Fixes #166 #167 #171

Special notes for your reviewer:

Release note:

Selectable timezone for maintenance window configuration on create cluster dialog

Cluster status indicator improvements
- Show checkmark instead of tractor during reconciliation (as long as no error occurred) gardener/dashboard#166
- Fixed alignments and sizes of different status icons

Updates to cluster version button and update dialog gardener/dashboard#171
- Removed shadow of version button
- Removed update button margin to not increase table row height
- Always show update dialog with warning color
- Show version upgrade path in dropdown selection
- No pre-selected version, so that an update action is more explicit
- Added warning text for patch case

Cluster list columns "version" and "purpose" now visible by default gardener/dashboard#167

@grolu
Improved Status Icon
22f7446 
- Show checkmark instead of tractor during reconciliation (if no error occurred)
- Fixed alignments and sizes of different icons
- Added a width to the parent div & centered icon inside
@grolu
Updates to ShootVersion Dialog #171
3406381 
- Removed shadow of button
- Always show update dialog with warning color
- Show version upgrade path in dropdown selection
@grolu
Made columns version and purpose visible by default as discussed in #167
15ad7f4
@grolu
Removed update button margin to not expand row height when displaying…
ede1048 
… version button
@grolu
removed darken-2 for action buttons
3c1a720
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@grolu grolu added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 18, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 18, 2018
@grolu grolu added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 18, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 18, 2018
@grolu grolu added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 18, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2018
@grolu grolu removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2018
petersutter
petersutter approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit de0364a into master Sep 19, 2018
@petersutter petersutter deleted the ui_improvements branch September 19, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear reconcile message and icon for end users
4 participants
@grolu @CLAassistant @petersutter @gardener-robot-ci-1