Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix-1.69] Remove kubernetes.io/ingress.class annotation in values.yaml #1499

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
Fixes an issue where the helm deployment failed with the error

Helm upgrade failed: failed to create resource: Ingress.extensions "gardener-dashboard-ingress" is invalid: annotations.kubernetes.io/ingress.class: Invalid value: "nginx": can not be set when the class field is also set

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed an issue where the helm deployment failed with the error `annotations.kubernetes.io/ingress.class: Invalid value: "nginx": can not be set when the class field is also set`
The default ingress class annotation under `Values.global.dashboard.ingress.annotations['kubernetes.io/ingress.class']` will not be set anymore. Instead, the ingress class name will be set using `Values.global.dashboard.ingress.ingressClassName`

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 1, 2023
@petersutter petersutter changed the title Remove kubernetes.io/ingress.class annotation in values.yaml [hotfix-1.69] Remove kubernetes.io/ingress.class annotation in values.yaml Jun 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 1, 2023
@petersutter
Copy link
Contributor Author

cc @JensAc - thanks for reporting

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 1, 2023
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2023
@petersutter petersutter merged commit d814e6a into hotfix-1.69 Jun 2, 2023
11 checks passed
@petersutter petersutter deleted the bug/hotfix-ingress-class-name branch June 2, 2023 09:29
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants