Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button to hibernate and wake-up cluster #203

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Added ability to to hibernate (and wake-up) clusters to save costs when they are temporarily not needed.

Which issue(s) this PR fixes:
Fixes #28

Special notes for your reviewer:

Release note:

You can now hibernate and wake-up clusters on the cluster details page

Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the user can hibernate in the UI via a button click, the fact that hibernated; reconcile processing state shows a checkmark with a circular process, is even more confusing. We should discuss what to show to the user in this case. Maybe we could only show zzz without a circle, as the user probably does not care about reconciling of hibernated clusters. What do you think?

@petersutter
Copy link
Member Author

@rfranzke is it crucial for an operator to see if the reconcile is running for a hibernated shoot? If yes I would suggest to show the progress circle with zzz
but in any case, I agree with @grolu that showing the checkmark with a progress circle in this case is confusing

@rfranzke
Copy link
Member

rfranzke commented Oct 5, 2018

If it's a reconciliation operation I guess we can skip it in case the shoot is hibernated, however, any error that may occur or any other operation should be visible.

@petersutter petersutter force-pushed the hibernate branch 4 times, most recently from 26def19 to c6d3fdd Compare October 8, 2018 10:26
@petersutter petersutter requested a review from grolu October 8, 2018 14:21
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petersutter petersutter merged commit efe3d58 into master Oct 8, 2018
@petersutter petersutter deleted the hibernate branch October 16, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate/Wake-Up Clusters
3 participants