Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning if deleting shoot with deactivated reconciliation #275

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Dec 20, 2018

What this PR does / why we need it:
Show warning in case user deletes shoot with deactivated reconciliation

Which issue(s) this PR fixes:
Fixes #225

Special notes for your reviewer:

Release note:

Show warning if deleting a cluster for which reconciliation is deactivated

Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit a4756ae into master Dec 20, 2018
@petersutter petersutter deleted the delete_deactivated_reconciliation branch January 8, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a Shoot that has reconciliation deactivated
2 participants