Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open project/clusters when searching on enter #397

Merged
merged 2 commits into from
Jun 4, 2019
Merged

open project/clusters when searching on enter #397

merged 2 commits into from
Jun 4, 2019

Conversation

grolu
Copy link
Contributor

@grolu grolu commented May 28, 2019 •
edited by petersutter
Loading

What this PR does / why we need it:
open project/clusters when searching on enter

Which issue(s) this PR fixes:
Fixes #381

Special notes for your reviewer:

Release note:

Project selection menu: When filtering projects you can press enter to choose the project in case there is only one filter result

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2019
@petersutter
Copy link
Member

submit on enter only in case of exactly one match

petersutter
petersutter approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit fef3fec into master Jun 4, 2019
@grolu grolu deleted the open_on_enter branch June 4, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please open project/clusters when searching on enter
3 participants
@grolu @petersutter @gardener-robot-ci-1