Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use status.hibernated to determine cluster hibernation status #539

Merged
merged 16 commits into from
Jan 20, 2020
Merged

use status.hibernated to determine cluster hibernation status #539

merged 16 commits into from
Jan 20, 2020

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jan 7, 2020 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #495

Special notes for your reviewer:

Release note:

When waking up a hibernated cluster, the cluster status indicator only turns green after the cluster has been started. A loading indicator is shown in the `Hibernation` section of the `Lifecycle` card on the cluster details page while the hibernation status is progressing

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 7, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 13, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 13, 2020
@grolu
Do not use status seed name, always use seed name from shoot spec
af4629f 
Use status seed name to show control plane migration
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2020
@grolu @petersutter
Update frontend/src/components/ShootSeedName.vue
f99ec45 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
grolu and others added 3 commits January 16, 2020 15:14
@grolu @petersutter
Update frontend/src/components/ShootSeedName.vue
2947db6 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@grolu @petersutter
Update frontend/src/components/ShootDetails/ShootInfrastructureCard.vue
f56a23d 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@grolu @petersutter
Update frontend/src/components/ShootHibernation/ChangeHibernation.vue
fe8462b 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@grolu @petersutter
Update frontend/src/components/ShootHibernation/ChangeHibernation.vue
10c3786 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@grolu
Merge branch 'master' into hibernation_symbol
11d2526 
# Conflicts:
#	frontend/src/components/ShootDetails/ShootInfrastructureCard.vue
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
grolu
grolu commented Jan 20, 2020
View reviewed changes
frontend/src/components/ShootStatus.vue Outdated
}

console.log('extendedTitle', extendedTitle);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2020
@petersutter petersutter self-requested a review January 20, 2020 13:36
petersutter
petersutter approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit 64f8c00 into master Jan 20, 2020
@grolu grolu deleted the hibernation_symbol branch January 20, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hibernation symbol
5 participants
@grolu @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3