Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust shoot cp ingress endpoints #548

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Adjust shoot cp ingress endpoints #548

merged 1 commit into from
Jan 16, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jan 16, 2020 •
edited by grolu
Loading

What this PR does / why we need it:
Several endpoints for shoot control plane components have changed with gardener/gardener#1769.

This PR adapts to that change.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The new URLs for `AlertManager`, `Kibana`, `Grafana` and `Prometheus` (introduced by https://github.com/gardener/gardener/pull/1769) are now shown on the cluster overview page

:warning: This Dashboard version is not compatible with Gardener versions prior 0.34.x

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@timuthy @holgerkoser
Adjust shoot cp ingress endpoints
1359345 
See gardener/gardener#1769

Co-authored-by: Holger Koser <holger.koser@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
holgerkoser
holgerkoser approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

grolu
grolu approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petersutter petersutter merged commit 1f2160c into gardener:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

@petersutter petersutter Awaiting requested review from petersutter petersutter is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@timuthy @holgerkoser @grolu @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3