Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member roles #642

Merged
merged 14 commits into from Mar 30, 2020
Merged

Member roles #642

merged 14 commits into from Mar 30, 2020

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Mar 24, 2020 •
edited

What this PR does / why we need it:
This PR adds the possibility to edit member roles in the UI

Screen Shot 2020-03-30 at 09 43 18

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Project member roles can now be configured in the member section

@grolu
[WIP] merged role support from other branch
d095d53
@grolu
Merge branch 'master' into member_roles
48697cc 
# Conflicts:
#	frontend/src/components/ProjectServiceAccountRow.vue
#	frontend/src/components/ProjectUserRow.vue
#	frontend/src/pages/Members.vue
#	frontend/src/utils/index.js
@grolu
fixed lint errors
0c9584b
@grolu
update member roles
8984043 
adapted tests
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2020
@petersutter
Copy link
Contributor

call selfsubjectrulesreview after changing the roles of own user

holgerkoser
holgerkoser reviewed Mar 25, 2020
View reviewed changes
backend/lib/services/members.js Outdated Show resolved Hide resolved
backend/lib/services/members.js Outdated Show resolved Hide resolved
backend/lib/services/members.js Outdated Show resolved Hide resolved
backend/lib/services/members.js Outdated Show resolved Hide resolved
@grolu
Copy link
Contributor Author

grolu commented Mar 26, 2020

add confirmation dialog when deleting a member

done

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020
@grolu
changed colors
9f9ca4a 
current user handling
refresh rules after editing own member roles
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
holgerkoser
holgerkoser approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the names toOneMemberRoleArray and toMemberRoleRolesArrays this PR lgtm. At least ...RoleRolesArrays makes no sense.

@grolu @holgerkoser
Update backend/lib/utils/index.js
94c4cf2 
Co-Authored-By: Holger Koser <holger.koser@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@grolu @holgerkoser
Update backend/lib/utils/index.js
2b16cd5 
Co-Authored-By: Holger Koser <holger.koser@sap.com>
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@grolu
Copy link
Contributor Author

grolu commented Mar 30, 2020

apart from the names toOneMemberRoleArray and toMemberRoleRolesArrays this PR lgtm. At least ...RoleRolesArrays makes no sense.

Yes maybe I was a bit too creative ;)

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2020
@petersutter petersutter self-requested a review March 30, 2020 19:17
petersutter
petersutter approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu grolu merged commit 1f826ae into master Mar 30, 2020
@grolu grolu deleted the member_roles branch April 3, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@grolu @petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3