New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Member roles #642
Member roles #642
Conversation
# Conflicts: # frontend/src/components/ProjectServiceAccountRow.vue # frontend/src/components/ProjectUserRow.vue # frontend/src/pages/Members.vue # frontend/src/utils/index.js
adapted tests
call selfsubjectrulesreview after changing the roles of own user |
done |
current user handling refresh rules after editing own member roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the names toOneMemberRoleArray
and toMemberRoleRolesArrays
this PR lgtm. At least ...RoleRolesArrays
makes no sense.
Co-Authored-By: Holger Koser <holger.koser@sap.com>
Co-Authored-By: Holger Koser <holger.koser@sap.com>
Yes maybe I was a bit too creative ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
This PR adds the possibility to edit member roles in the UI
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: