Update MAINTAINERS.md #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
msohn
commented
Jan 23, 2018
msohn
commented
- add missing github.com usernames
- no focus areas are given hence don't mention them
- add missing github.com usernames - no focus areas are given hence don't mention them
petersutter
approved these changes
Jan 23, 2018
grolu
added a commit
that referenced
this pull request
Mar 30, 2020
* [WIP] merged role support from other branch * fixed lint errors * update member roles adapted tests * no message * fixed typo * changes part #1 * changes part #2 * changed colors current user handling refresh rules after editing own member roles * fix lint errors * Update backend/lib/utils/index.js Co-Authored-By: Holger Koser <holger.koser@sap.com> * Update backend/lib/utils/index.js Co-Authored-By: Holger Koser <holger.koser@sap.com> * Changes as discussed Co-authored-by: Holger Koser <holger.koser@sap.com>
grolu
added a commit
that referenced
this pull request
Aug 13, 2020
* Support for adding additional zones for existing workers * Fix tests * improve feedback if zones cannot be selected * Some fixes * some code cleanup * Update frontend/src/components/ShootWorkers/ManageWorkers.vue Co-authored-by: Peter Sutter <peter.sutter@sap.com> * Update frontend/src/components/ShootWorkers/WorkerInputGeneric.vue Co-authored-by: Peter Sutter <peter.sutter@sap.com> * PR Feedback #1 * PR Feedback #2 * PR Feedback #3 * Fixed missing space in cluster self termination warning * Added confirmation required to worker dialog * Disable autofocus confirm input for worker dialog to prevent scrolling down to confirm field * use UNKNOWN_EXPIRED_TIMESTAMP constant * PR Feedback #4 * show zones as chips in selection * use lodash range * GDialog: wrap confirm input text with v-alert * Update backend/lib/routes/shoots.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update backend/lib/services/shoots.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update backend/test/acceptance/api.shoots.spec.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update backend/test/support/nocks/k8s.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update frontend/src/utils/api.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update frontend/src/utils/api.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update frontend/src/components/ShootWorkers/WorkerConfiguration.vue Co-authored-by: Holger Koser <holger.koser@sap.com> * Update frontend/src/components/ShootWorkers/WorkerConfiguration.vue Co-authored-by: Holger Koser <holger.koser@sap.com> * changes as discussed * fixed import * improved confirm v-alert Co-authored-by: Peter Sutter <peter.sutter@sap.com> Co-authored-by: Holger Koser <holger.koser@sap.com>
grolu
added a commit
that referenced
this pull request
Oct 28, 2020
* WIP * Fixed some issues * WIP * WIP * WIP * Added tests * WIP * Added tests * fixed build * Fixed foreign member deletion dialog * Fixed unit tests * Update frontend/src/components/dialogs/MemberDialog.vue Co-authored-by: Peter Sutter <peter.sutter@sap.com> * Update frontend/src/components/dialogs/MemberDialog.vue Co-authored-by: Peter Sutter <peter.sutter@sap.com> * PR Feedback #1 * fixed owner camel case * Update backend/lib/services/members.js Co-authored-by: Holger Koser <holger.koser@sap.com> * PR feedback #2 * PR Feedback #3 * fix build errors * PR Feedback #4 * Fixed issues * Show foreign service accounts with icon in list * Switched to OO, tests still need to be adapted * Adapted tests to new member management classes * Apply suggestions from code review Co-authored-by: Peter Sutter <peter.sutter@sap.com> * Frontend changes as requested in PR * Backend changes as requested * rm awaits for synchronous list call * fail when trying to remove member by updating with empty roles * changes as requested * changes as requested #2 * Update backend/lib/services/members.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * Fixed suggestion * Fixed lint errors Co-authored-by: Peter Sutter <peter.sutter@sap.com> Co-authored-by: Holger Koser <holger.koser@sap.com>
grolu
added a commit
that referenced
this pull request
Dec 16, 2020
* Added support to read controllerregistration resources Show dropdown for registered network extensions Show network etension list (for operators) * renaming * renaming * renaming * renaming * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * Update frontend/src/store/index.js Co-authored-by: Holger Koser <holger.koser@sap.com> * PR Feedback #1 * Fixed lint error * Allow fetching networking types with non admin user * Added test for networking types endpoint * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> Co-authored-by: Peter Sutter <peter.sutter@sap.com> * Update backend/lib/services/controllerregistrations.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Fixed tests and frontend routes * changes as discussed * fix and add snapshoots * inline code Co-authored-by: Holger Koser <holger.koser@sap.com> Co-authored-by: Peter Sutter <peter.sutter@sap.com>
grolu
added a commit
that referenced
this pull request
Dec 18, 2020
* A few minor fixes and some cosmetic changes to members management * read only projectName from cache * add member description property * PR review I * Added rotate service account secret feature * Use data table for service account list * use data table for user account list * small fixes added roles help texts * fixed unused var * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * PR Feedback #1 * PR feedback #2 * row alignment * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * PR Feedback #3 * Small changes * Added sorting capabilities and limit description height in member table * fix column sorting * Refactored table column selection into re-usable component * make columns selectable & resetable + local storage * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * changes as discussed * PR Feedback * Added handling for members where serviceaccount has been removed * Apply suggestions from code review Co-authored-by: Holger Koser <holger.koser@sap.com> * updated member snapshot file * Fixed lint errors * Orphaned Robot Members (#914) * orphaned serviceaccounts * Simplify extend check Co-authored-by: Holger Koser <holger.koser@sap.com>
grolu
added a commit
that referenced
this pull request
Aug 2, 2021
* Support managing of DNS Secrets * Renamed infrastructure service to cloudprovider * update logos * cropped cloudflare and infoblox icons * WIP * WIP * Finished implementation of create shoot manage dns section added first attempt of component state store synchronization * WIP Show DNS Configuration on Shoot Details Page * Fixed Layout * Show worker group machine image icon Show detailed dns provider information in popper Update dns implementation cluster domain immutable count dns secret references * fixed some validation & dialog reset issues * small fixes * Some changes to naming and fixed secret creation on poups * validate: primary dns provider cannot be changed after cluster creation * rm log stmt * Added DNS Provider Secret Documentation * Fixed some DNS Provider naming glitches * Read the available dns provider list from controller registrations Added check if DNS provider can be used as primary DNS provider * Fixed icon layout in v-selects * Reverted template changes Rm .secrets.baseline * Fixed Create Secret Provider List Fixed Create Secret Table gap Show domain / default provider only when first dns row added Filter shoot dns providers w/o valid secret binding Filter secretbindings with reference to other namespace * Allow dns provider row components to line break Use more space for large dialogs * Added test * added comment * changes part #1 * Update backend/__fixtures__/secretbindings.js Co-authored-by: Holger Koser <holger.koser@sap.com> * Update backend/test/acceptance/api.cloudProviderSecrets.spec.js * changes part #2 * use dynamic components in secret dialog wrapper * Added tests for /spec/dns and /spec/addons routes * fixed whitespace * Direct update of store for dns configuration (#1068) * direct update of store for dns configuration * removed some leftovers * some small improvements * PR feedback I * Refactor select-secret and handle invalid dns config * Fixed validation issue for generated shoot domains * Update frontend/src/assets/flatcar.svg Co-authored-by: Peter Sutter <peter.sutter@sap.com> * rm memoryone svg (too large and does not fit in icon box anyway) * Some final fixes and improvement proposals for enh/dns-secret (#1069) * PR feedback * rm whitespace * some fixes * rm emit * Some fixes Co-authored-by: Holger Koser <holger.koser@sap.com> Co-authored-by: Peter Sutter <peter.sutter@sap.com>
grolu
added a commit
that referenced
this pull request
Aug 16, 2022
* Implemented Disable Gardener provided static admin kubeconfig * PR Feedback * PR Feedback #1 * PR Feedback #2 * PR Feedback * Show kubeconfig tile only if kubeconfig available OR user can patch shoots * Update frontend/src/components/StaticTokenKubeconfigSwitch.vue Co-authored-by: Peter Sutter <peter.sutter@sap.com> Co-authored-by: Peter Sutter <peter.sutter@sap.com>
grolu
added a commit
that referenced
this pull request
Jan 13, 2023
* Added an option to freeze the cluster list * Added issue since column * allow sorting after freeze show freeze option only for all projects & admin reset freeze when navigating * Fixed shoot getter tests, currently no additional test for freeze logic added as implementation is in poc state * Add new items to the end of the list Added an info alert when the freezing mode is activated * - Reverted logic to include new items in the list - Show number of new items since freeze as badge on the switch - Fixed search in focus mode - Added max-height & overflow: scroll to table menu * Fixed a bug in sorting logic, refactored static / regular sorting logic to dedicated methods * Added tests * Apply suggestions from code review Co-authored-by: Peter Sutter <peter.sutter@sap.com> Co-authored-by: Holger Koser <holger.koser@sap.com> * PR Feedback #1 * fixed lint errors * PR Feedback * Allow pointer events for navigating to stale shoots Fixed missing freeze reset when route changes * Cache filtered shoots as skeletons (required properties only) * Fixed tests * Show tooltip when filters are disabled * Fixes * PR Feedback * renamed vars * aligned comments * Simplified find functions * Adapted tests to changed freeze logic * Optimized stale UI * Only store copies of shoots that are actually stale, always have the last available data Keep lost of uidsAtFreeze in store adapted tests Show stale information as tooltip / in toolbar of poppers * rm unused import * Adapted tests Improved stale shoot colors * Moved freezed sorting logic to component Disable table column sort options in case freeze switch is active * log error in case stale shoot item is not found * fixes * PR Feedback #1 * PR Feedback #2 * Fixed test * Fixed issue with shoots that are no longer in filteredShoots but still in shoots * Set positionFixed: true for poppers to avoid layout issues on top of absolute positioned elements * Small code improvements Co-authored-by: Peter Sutter <peter.sutter@sap.com> Co-authored-by: Holger Koser <holger.koser@sap.com>
grolu
added a commit
that referenced
this pull request
Jan 23, 2023
* Implemented control plane high availability configuration * fixed lint error * Some changes due to UI feedback * Added help text and possibility to configure additional help texts. * fixed failure tolerance display replace default more information link in case help text is configured * fixed lint error * Fixed Some naming / spelling issues * zones might not be set * PR Feedback * PR Feedback #1 * PR Feedback #2 * PR Feedback #3 * PR Feedback * Also removed ::v-deep .v-card from the other components that use g-popper
grolu
added a commit
that referenced
this pull request
Sep 4, 2023
* Show root cause for failed requests in appstore alerts * PR Feedback #1 * removed code from seterror
grolu
added a commit
that referenced
this pull request
Sep 22, 2023
* Support creation of workerless clusters * Support workerless clusters on cluster details page * Fixed networking type validation for workerless shoots * Added missing Worker Dialog modification warning * Added worker pool maximum value check >= zone count for system component workers * Added worker column to shoot list * Disable Terminal runtime settings for workerless shoots * PR Feedback #1 * PR Feedback #2 * Fixed lint errors * Added explicit code in search function to filter for workerless shoots * Fixed wrong behavior / usage of hasShootWorkerGroups computed property (due to renaming) Do not show terminal in access card if shoot is workerless and user is not an operator * Small fixes * Show workerless clusters as chip * Do not pass shoot-item * PR Feedback * re-added load * Fixed router navigation guard Cleaned up unused mixin * Fixed navigation hook * changed error text * PR Feedback * removed workerless logic from maintenance components fixed missing reset call that sets the data in case of start maintenance * fixed workerless chip alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.