Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user error code for cluster cleanup #643

Merged
merged 1 commit into from Mar 25, 2020
Merged

Add user error code for cluster cleanup #643

merged 1 commit into from Mar 25, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Mar 24, 2020 •
edited by grolu

What this PR does / why we need it:
This PR adds a new user error code ERR_CLEANUP_CLUSTER_RESOURCE.

See gardener/gardener#2090.

Special notes for your reviewer:

Release note:

Shoot clusters which are stuck in deletion because resources within the cluster can't be removed properly, will be shown as a user related issue

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2020
@petersutter petersutter self-requested a review March 24, 2020 16:34
petersutter
petersutter approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

grolu
grolu approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grolu
Copy link
Contributor

grolu commented Mar 25, 2020

Thank you @timuthy

@petersutter petersutter merged commit 8b2b632 into gardener:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timuthy @grolu @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3