Add error code for cluster cleanup #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gardener/dashboard-maintainers |
rfranzke
reviewed
Mar 24, 2020
rfranzke
previously approved these changes
Mar 25, 2020
timuthy
force-pushed
the
feature.cleanup-err-code
branch
from
feee8ac
to
3719a90
Compare
timebertt
reviewed
Mar 25, 2020
timuthy
force-pushed
the
feature.cleanup-err-code
branch
from
3719a90
to
0b0bb44
Compare
rfranzke
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new error code
ERR_CLEANUP_CLUSTER_RESOURCESwhich indicates that resources in the shoot cluster are stuck in deletion.This allows Gardener users to react accordingly, e.g. the Gardener-Dashboard can show this kind of error as an user related error.
Special notes for your reviewer:
extensions.gardener.cloudalready contains a known error code then this one is reused rather than re-matching the Regex. I see that we need a clear error code contract between Gardener and related extensions but don't want to introduce it in this PR. I'll create an issue and will implement it in further PRs.Release note: