Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to internal website #353

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Removed references to internal website #353

merged 1 commit into from
Jun 20, 2022

Conversation

n-boshnakov
Copy link
Contributor

What this PR does / why we need it:
This PR removes links in the FAQ that point to internal pages, due to these questions originally coming from the internal Gardener Github.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@n-boshnakov n-boshnakov requested a review from a team as a code owner June 20, 2022 10:59
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 20, 2022
@n-boshnakov
Copy link
Contributor Author

/review @JordanJordanov

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 20, 2022
JordanJordanov
JordanJordanov approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@JordanJordanov JordanJordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 20, 2022
@JordanJordanov JordanJordanov merged commit 9be48b4 into master Jun 20, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 20, 2022
@vpnachev vpnachev deleted the fix-faq-links branch June 22, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanJordanov JordanJordanov JordanJordanov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@n-boshnakov @JordanJordanov @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot