-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2e tests using emulators for cloud providers [ aws, gcp, azure ] #743
base: master
Are you sure you want to change the base?
Conversation
@anveshreddy18 You need rebase this pull request with latest master branch. Please check. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | RSA Private Key | 5454c29 | hack/e2e-test/infrastructure/kind/kubeconfig | View secret | |
- | RSA Private Key | dd4a097 | hack/e2e-test/infrastructure/kind/kubeconfig | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
What this PR does / why we need it:
This PR enables e2e tests ( cluster based tests ) to be run with the
emulators
of 3 major cloud providers i.e AWS, GCP, AZURE. And of course can be run with the real infra as well. The reason for using emulators is to reduce the cost of using real infra every time a PR is raised because with the enablement of e2e tests with this PR, these tests will be run as prow job for every PR.This PR also partially updates the outdated charts to reflect the changes made to the backup-restore over the years. This will help the users with setting up
backup-restore
effortlessly and also helps the developers with testingetcdbr
standaloneWhich issue(s) this PR fixes:
Fixes #722
Special notes for your reviewer:
Release note: