-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2e tests using emulators for cloud providers [ aws, gcp, azure ] #743
Open
anveshreddy18
wants to merge
9
commits into
gardener:master
Choose a base branch
from
anveshreddy18:enable-e2e
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dd4a097
Enable e2e tests with cloud provider emulators for aws,gcp,azure
anveshreddy18 8b7bc47
Minor cleanup
anveshreddy18 5454c29
Remove kubeconfig and add it to .gitignore
anveshreddy18 3f37a55
Fix make check error
anveshreddy18 8d1c313
add docs, cleanup
anveshreddy18 b7580db
Add steps for setup,test,clean & fixed a failing test
anveshreddy18 c40c8b5
Setup makefile for installing required tools
anveshreddy18 a711dc5
Make git track hack/tools/bin dir
anveshreddy18 ec1496b
Update docs & delete the objects of gcp bucket in parallel
anveshreddy18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,8 @@ | |
.glide/ | ||
|
||
# Build Binaries | ||
bin | ||
/bin | ||
/hack/tools/bin | ||
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason to add the |
||
test/output | ||
test/e2e_test_data | ||
default.bkp* | ||
|
@@ -28,6 +29,9 @@ compctedsnap.bkp* | |
.vscode | ||
.idea/ | ||
|
||
# kubeconfig | ||
hack/e2e-test/infrastructure/kind/kubeconfig | ||
|
||
# developers workspace | ||
tmp | ||
dev | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
chart/etcd-backup-restore/templates/etcd-peer-service.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
name: {{ .Release.Name }}-etcd-peer | ||
namespace: {{ .Release.Namespace }} | ||
labels: | ||
app.kubernetes.io/name: etcd | ||
app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
app.kubernetes.io/instance: {{ .Release.Name }} | ||
spec: | ||
publishNotReadyAddresses: true | ||
type: ClusterIP | ||
clusterIP: None | ||
clusterIPs: | ||
- None | ||
internalTrafficPolicy: Cluster | ||
imFamilyPolicy: SingleStack | ||
sessionAffinity: None | ||
selector: | ||
app.kubernetes.io/name: etcd | ||
app.kubernetes.io/instance: {{ .Release.Name }} | ||
ports: | ||
- name: peer | ||
protocol: TCP | ||
port: {{ .Values.servicePorts.server }} | ||
targetPort: {{ .Values.servicePorts.server }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these variables being exported as env variables when they weren't needed to be exposed before?
The
aws
cli picks up credentials from.aws
that is created in this function anyway, right?