Disable ServiceAccount automount when --disable-etcd-serviceaccount-automount=true
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-automount=true`
gardener-robot
added
area/security
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
rfranzke
changed the title
ServiceAccount automount when --disable-etcd-serviceaccount-automount=true`ServiceAccount automount when --disable-etcd-serviceaccount-automount=true
18 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
What this PR does / why we need it:
This PR introduces a new CLI flag
--disable-etcd-serviceaccount-automount(default:false) which sets the.automountServiceAccountToken=falsein theServiceAccountfor etcds if set totrue. This can be used in conjunction withWhich issue(s) this PR fixes:
Part of gardener/gardener#4659
Part of gardener/gardener#4878
Special notes for your reviewer:
/cc @timuthy
Release note:
When `--disable-etcd-serviceaccount-automount` is set to `true` then the `.automountServiceAccountToken` will be set to `false` for the `ServiceAccount` created for etcd.