-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statefulset PreDeploy flow checks for pod readiness if labels were patched #841
Statefulset PreDeploy flow checks for pod readiness if labels were patched #841
Conversation
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hi @shreyas-s-rao , |
@ishan16696 this is a good suggestion in general, but atleast as of today druid does not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
yeah, let's discuss this later . As of now, we can go ahead with this PR. |
How to categorize this PR?
/area quality
/kind bug
What this PR does / why we need it:
Statefulset PreDeploy flow checks for pod readiness if labels were patched. This ensures there is no transient quorum loss due to back-to-back double rolling of sts pods during downgrade of etcd-druid from master/v0.23.0+ version to v0.22.x version.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @unmarshall @seshachalam-yv @ishan16696
Release note: