Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-tree volume plugin tags to CSI provisioned volumes #256

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jan 15, 2021

/area storage
/kind bug
/priority normal
/platform aws

This PR configures the csi-provisioner and aws-ebs-csi-driver to add in-tree volume plugin tags to volumes to keep the backwards-compatibility. See kubernetes-sigs/aws-ebs-csi-driver#530

Currently a volume provisioned with the in-tree volume plugin has the following tags:

KubernetesCluster                        shoot--foo--bar1     
Name                                     shoot--foo--bar1-dynamic-pvc-a78c281f-78d5-46cd-8849-3fc2bd04ab28     
kubernetes.io/cluster/shoot--foo--bar1   owned     
kubernetes.io/created-for/pv/name        pvc-a78c281f-78d5-46cd-8849-3fc2bd04ab28     
kubernetes.io/created-for/pvc/name       pvc-name
kubernetes.io/created-for/pvc/namespace  default

Currently (before this PR) a volume provisioned with CSI has the following tags:

CSIVolumeName                             pv-shoot--foo--bar2-40e919e4-95f2-4808-8539-a4d0547b4aff     

After this PR a new volume provisioned with CSI has the following tags:

CSIVolumeName                             pv-shoot--foo--bar2-40e919e4-95f2-4808-8539-a4d0547b4aff     
Name                                      shoot--foo--bar2-dynamic-pv-shoot--foo--bar2-40e919e4-95f2-4808-8539-a4d0547b4aff
kubernetes.io/cluster/shoot--foo--bar2    owned
kubernetes.io/created-for/pv/name         pv-shoot--foo--bar2-40e919e4-95f2-4808-8539-a4d0547b4aff
kubernetes.io/created-for/pvc/name        pvc-name
kubernetes.io/created-for/pvc/namespace   default

Fixes #255

Release note:

Volumes provisioned with CSI will now have the in-tree volume plugin tags. Until now the CSI volumes had no tags at all. This is required to keep CSI plugin backwards-compatible with the in-tree volume plugin.

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner January 15, 2021 11:13
@gardener-robot gardener-robot added area/storage Storage related kind/bug Bug platform/aws Amazon web services platform/infrastructure priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 15, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2021
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 16, 2021
@ialidzhikov ialidzhikov merged commit 091e2e8 into gardener:master Jan 18, 2021
@ialidzhikov ialidzhikov deleted the fix/csi-volume-tags branch January 18, 2021 18:43
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New storage provisioner ebs.csi.aws.com does not add any tags to aws ebs volumes provisioned by it
4 participants