Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.19] Add in-tree volume plugin tags to CSI provisioned volumes #257

Merged
merged 1 commit into from
Jan 19, 2021
Merged

[release-v1.19] Add in-tree volume plugin tags to CSI provisioned volumes #257

merged 1 commit into from
Jan 19, 2021

Conversation

ialidzhikov
Copy link
Member

Cherry pick of #256 on release-v1.19.

#256: Add in-tree volume plugin tags to CSI provisioned volumes

Release note:

Volumes provisioned with CSI will now have the in-tree volume plugin tags. Until now the CSI volumes had no tags at all. This is required to keep CSI plugin backwards-compatible with the in-tree volume plugin.

@ialidzhikov
Add in-tree volume plugin tags to CSI provisioned volumes
77f3b95 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner January 18, 2021 20:21
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 18, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 18, 2021
vpnachev
vpnachev approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 19, 2021
@rfranzke rfranzke merged commit 24689b2 into gardener:release-v1.19 Jan 19, 2021
@ialidzhikov ialidzhikov deleted the cherrypick/csi-volume-tags branch January 23, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @vpnachev @rfranzke @gardener-robot-ci-3 @gardener-robot