Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #641

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #641

merged 1 commit into from
Nov 4, 2022

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented Nov 3, 2022 •
edited

How to categorize this PR?

/area open-source
/kind cleanup
/platform aws

What this PR does / why we need it:
Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations

Which issue(s) this PR fixes:
Fixes #kubernetes/kubernetes#79548

Special notes for your reviewer:

Release note:

scheduler.alpha.kubernetes.io/critical-pod annotation is removed as pod priority (spec.priorityClassName) is used instead to mark pods as critical

@gardener-robot
Copy link

@dimitar-kostadinov Label area/open-source| does not exist.

@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 3, 2022
@gardener-robot gardener-robot added the area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related label Nov 3, 2022
@dimitar-kostadinov dimitar-kostadinov mentioned this pull request Nov 3, 2022
Merged
@dkistner dkistner merged commit cca79e4 into gardener:master Nov 4, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 4, 2022
@dimitar-kostadinov dimitar-kostadinov deleted the remove-critical-pod-annotation branch November 4, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dimitar-kostadinov @gardener-robot @dkistner @gardener-robot-ci-3