Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated cluster creation tutorial #402

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Updated cluster creation tutorial #402

merged 3 commits into from
Nov 26, 2021

Conversation

n-boshnakov
Copy link
Contributor

@n-boshnakov n-boshnakov commented Nov 17, 2021 •
edited
Loading

How to categorize this PR?

/area documentation
/kind enhancement
/platform azure

What this PR does / why we need it:
This PR updates the content and screenshots of the Kubernetes cluster creation tutorial with Azure.
Which issue(s) this PR fixes:
Part of gardener/documentation#287

Special notes for your reviewer:

Release note:

NONE

@n-boshnakov n-boshnakov requested review from a team as code owners November 17, 2021 15:41
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2021
@n-boshnakov n-boshnakov marked this pull request as draft November 17, 2021 15:42
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2021
@n-boshnakov
Copy link
Contributor Author

/review @ialidzhikov

@gardener-robot gardener-robot added area/documentation Documentation related platform/azure Microsoft Azure platform/infrastructure labels Nov 17, 2021
@gardener-robot
Copy link

@n-boshnakov Label area/enhancement does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 17, 2021
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Nov 18, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2021
@n-boshnakov n-boshnakov marked this pull request as ready for review November 18, 2021 12:56
@ialidzhikov ialidzhikov mentioned this pull request Nov 22, 2021
Closed
4 tasks
ialidzhikov
ialidzhikov approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/squash

@gardener-robot gardener-robot added merge/squash Should be merged via 'Squash and merge' reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 26, 2021
dkistner
dkistner approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

/lgtm

@dkistner dkistner merged commit 868cac3 into gardener:master Nov 26, 2021
@n-boshnakov n-boshnakov deleted the update-cluster-tutorial branch May 20, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/documentation Documentation related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@n-boshnakov @gardener-robot @dkistner @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3