Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup natipmigration logic #406

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Cleanup natipmigration logic #406

merged 1 commit into from
Dec 1, 2021

Conversation

dkistner
Copy link
Member

How to categorize this PR?
/kind cleanup
/platform azure

What this PR does / why we need it:
Remove natgateway ip migration (ref: TODO(natipmigration)) logic which was required to migrate from azurerm provider v1 to v2.
The logic is now in since v1.15 and will be removed with v1.23.
This should be enough time to reconcile all Infrastructure resources. ref: #192

Release note:

The logic to migrate the Terraform natgateway state will be removed. In case there are `Infrastructure` resources that are created with < `v1.15` and not reconciled with >= `v1.15` they need to be reconciled before a release with this change is applied.

/invite @kon-angelo
/cc @ialidzhikov

@dkistner dkistner requested review from a team as code owners November 30, 2021 11:27
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels Nov 30, 2021
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 30, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2021
kon-angelo
kon-angelo reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/invite @ialidzhikov

@gardener-robot gardener-robot removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 30, 2021
@dkistner dkistner merged commit 8fe675f into gardener:master Dec 1, 2021
@dkistner dkistner deleted the remove-natipmigration-logic branch December 1, 2021 11:31
@kon-angelo kon-angelo mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dkistner @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot