-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User lenient decoder for infra status #414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kon-angelo Labels area/todo, kind/todo do not exist. |
gardener-robot
added
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Dec 9, 2021
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 9, 2021
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Dec 9, 2021
/test |
Testrun: e2e-8bvq4 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 25m25s | +---------------------+---------------------+-----------+----------+ |
dkistner
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
kind/bug
Bug
kind/test
Test
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/azure
Microsoft Azure platform/infrastructure
reviewed/lgtm
Has approval for merging
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
/platform azure
What this PR does / why we need it:
Due to the removal of the
natGatewayPublicIpMigrated
field in #406 currently existing shoots may have their reconciliation blocked if they try to reconcile worker resources (e.g. scaling a worker pool) without first reconciling the Infrastructure.The issue occurs due to the extra field in existing infrastructureStatus that is not allowed from the strict decoder. This PR uses a non-strict decoder to decode the infrastructureStatus.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: