Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User lenient decoder for infra status #414

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Dec 9, 2021

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:
Due to the removal of the natGatewayPublicIpMigrated field in #406 currently existing shoots may have their reconciliation blocked if they try to reconcile worker resources (e.g. scaling a worker pool) without first reconciling the Infrastructure.

The issue occurs due to the extra field in existing infrastructureStatus that is not allowed from the strict decoder. This PR uses a non-strict decoder to decode the infrastructureStatus.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Azure provider extension now uses non-strict decoder for InfrastructrureStatus resources.

@kon-angelo kon-angelo requested review from a team as code owners December 9, 2021 15:07
@gardener-robot gardener-robot added the platform/azure Microsoft Azure platform/infrastructure label Dec 9, 2021
@gardener-robot
Copy link

@kon-angelo Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 9, 2021
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug labels Dec 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 9, 2021
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Dec 9, 2021

Testrun: e2e-8bvq4
Workflow: e2e-8bvq4-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 25m25s   |
+---------------------+---------------------+-----------+----------+

@kon-angelo kon-angelo added this to the v1.23 milestone Dec 9, 2021
@kon-angelo kon-angelo closed this Dec 10, 2021
@kon-angelo kon-angelo reopened this Dec 10, 2021
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 10, 2021
@dkistner dkistner merged commit 46d538a into gardener:master Dec 10, 2021
@kon-angelo kon-angelo deleted the status-decoder branch December 12, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants