Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.20 #219

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Support for Kubernetes v1.20 #219

merged 3 commits into from
Dec 18, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Dec 14, 2020 •
edited
Loading

How to categorize this PR?

/area open-source usability
/kind enhancement
/priority normal
/platform gcp
/exp intermediate
/topology garden seed shoot

What this PR does / why we need it:
This PR adds support for 1.20 to the extension.

Which issue(s) this PR fixes:
Part of gardener/gardener#3260

Special notes for your reviewer:

  • ✅ Depends on Support for Kubernetes v1.20 gardener#3296
  • I have successfully validated the functionality as follows:
    • ✅ Create new clusters with versions < 1.20
    • ✅ Create new clusters with version = 1.20
    • ✅ Upgrade old clusters from version 1.19 to version 1.20
    • ✅ Delete clusters with versions < 1.20
    • ✅ Delete clusters with version = 1.20

Release note:

The GCP extension does now support shoot clusters with Kubernetes version 1.20. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md) before upgrading to 1.20.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure priority/normal topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 14, 2020
@rfranzke rfranzke mentioned this pull request Dec 14, 2020
Closed
@prashanth26
Copy link

/assign

@rfranzke
Copy link
Member Author

/ready as gardener/gardener#3296 got approved and merged now

@gardener-robot gardener-robot marked this pull request as ready for review December 17, 2020 07:21
@gardener-robot gardener-robot requested review from a team as code owners December 17, 2020 07:21
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@prashanth26
Copy link

The verify step seems to be failing. PTAL.

make generate needs to be run:
 M hack/api-reference/api.md
 M hack/api-reference/config.md
make: *** [Makefile:113: check-generate] Error 1

@rfranzke
Revendor gardener/gardener to support 1.20 K8s client creation
9b8359b
@rfranzke
Upgrade github.com/gardener/cloud-provider-gcp
249d048 
```feature dependency github.com/gardener/cloud-provider-gcp $307cc619b1015ce524bd9664e3bdd282cd9fe1a1
`k8s.io/legacy-cloud-providers` is now updated to `v0.17.15`.
```

```feature dependency github.com/gardener/cloud-provider-gcp $1af47f2faad282428bc4c6d294c39f8ed0d6a030
`k8s.io/legacy-cloud-providers` is now updated to `v0.18.13`.
```

```feature dependency github.com/gardener/cloud-provider-gcp $8e1ce1bcb3e54e8d98227f73066285dcee2cdc94
`k8s.io/legacy-cloud-providers` is now updated to `v0.19.5`.
```

```feature dependency github.com/gardener/cloud-provider-gcp $daa91983150ba42e9daeb696e469a0b052cffb93
`k8s.io/legacy-cloud-providers` is now updated to `v0.20.0`.
```

```improvement developer github.com/gardener/cloud-provider-gcp $f9fb62389b58368103389a6bf4391b2591e698aa
The alpine version has been updated to `v3.12.1`.
```

```improvement developer github.com/gardener/cloud-provider-gcp $f9fb62389b58368103389a6bf4391b2591e698aa
The Golang version has been updated to `v1.15.5`.
```
@rfranzke
Add Kubernetes 1.20 support to README.md
eada624
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Dec 17, 2020
@gardener-robot gardener-robot removed the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 17, 2020
prashanth26
prashanth26 approved these changes Dec 17, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

go.mod
@@ -9,7 +9,7 @@ require (
github.com/coreos/go-systemd/v22 v22.1.0
github.com/frankban/quicktest v1.9.0 // indirect
github.com/gardener/etcd-druid v0.3.0
github.com/gardener/gardener v1.13.1-0.20201130072421-4fcecc0519dd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change this to release version in future.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 17, 2020
DockToFuture
DockToFuture approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ialidzhikov
ialidzhikov approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit 906c286 into gardener:master Dec 18, 2020
@rfranzke rfranzke deleted the kubernetes-v1.20 branch December 18, 2020 13:11
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@DockToFuture DockToFuture DockToFuture approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees

@prashanth26 prashanth26

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rfranzke @prashanth26 @ialidzhikov @DockToFuture @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot