Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make admission check of min worker pool and number of zones backward compatible #352

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Make admission check of min worker pool and number of zones backward compatible #352

merged 2 commits into from
Nov 24, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area ops-productivity quality robustness usability
/kind bug
/platform gcp

What this PR does / why we need it:
Make admission check of min worker pool and number of zones backward compatible

Which issue(s) this PR fixes:
Fixes #351

Special notes for your reviewer:

Release note:

The admission webhook validating the minimum workers in a pool to be >= number of availability zones has been made backward compatible with shoot clusters that have been created before this admission check to be implemented.

@vpnachev vpnachev requested review from a team as code owners November 17, 2021 13:49
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related area/usability Usability related kind/bug Bug platform/gcp Google cloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2021
@vpnachev vpnachev force-pushed the admission/allow-shoot-update-requestes-not-chaging-worker-settings branch from b9df56b to b3744af Compare November 17, 2021 13:50
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2021
@vpnachev
Copy link
Member Author

/invite @AxiomSamarth

AxiomSamarth
AxiomSamarth previously approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@AxiomSamarth AxiomSamarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/apis/gcp/validation/shoot_test.go Show resolved Hide resolved
pkg/apis/gcp/validation/shoot.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 22, 2021
@vpnachev
Copy link
Member Author

/ping @gardener/gardener-extension-provider-gcp-maintainers
/ping @gardener/gardener-maintainers

@gardener-robot
Copy link

@gardener/gardener-extension-provider-gcp-maintainers

Message

/ping @gardener/gardener-extension-provider-gcp-maintainers
/ping @gardener/gardener-maintainers

@gardener-robot
Copy link

@gardener/gardener-maintainers

Message

/ping @gardener/gardener-extension-provider-gcp-maintainers
/ping @gardener/gardener-maintainers

@vpnachev
Copy link
Member Author

/invite @dkistner @rfranzke

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Nov 23, 2021
@ialidzhikov
Copy link
Member

/assign

ialidzhikov
ialidzhikov reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm. I have only 1 minor suggestion/question.

pkg/apis/gcp/validation/shoot.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Nov 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 24, 2021
ialidzhikov
ialidzhikov approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 24, 2021
@ialidzhikov ialidzhikov merged commit 0519cd7 into gardener:master Nov 24, 2021
@vpnachev vpnachev deleted the admission/allow-shoot-update-requestes-not-chaging-worker-settings branch November 24, 2021 11:28
@vpnachev vpnachev mentioned this pull request Nov 24, 2021
Merged
ialidzhikov pushed a commit that referenced this pull request Nov 24, 2021
@vpnachev @plkokanov
[release-v1.19] Automated cherry pick of #336: Slightly clarify shoot…
3ad2bc2 
….worker validation error #352: Make admission check of min worker pool and number of zones backward compatible (#354)

* Clarify autoscaling validation error

* Make admission check of min worker pool and number of zones backward compatible

* Use github.com/gardener/gardener/pkg/apis/core/helper.FindWorkerByName to get the old worker

Co-authored-by: Plamen Kokanov <plamen.kokanov@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@AxiomSamarth AxiomSamarth AxiomSamarth left review comments

@dkistner dkistner Awaiting requested review from dkistner

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@ialidzhikov ialidzhikov

Labels
area/ops-productivity Operator productivity related (how to improve operations) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related area/usability Usability related kind/bug Bug merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The worker validation prevents lifecycle operations from other controllers
7 participants
@vpnachev @gardener-robot @ialidzhikov @AxiomSamarth @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3