Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #515

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #515

merged 1 commit into from
Nov 14, 2022

Conversation

dimitar-kostadinov
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind cleanup
/platform gcp

What this PR does / why we need it:
Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations

Which issue(s) this PR fixes:
Fixes #kubernetes/kubernetes#79548

Special notes for your reviewer:

Release note:

scheduler.alpha.kubernetes.io/critical-pod annotation is removed as pod priority (spec.priorityClassName) is used instead to mark pods as critical

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 3, 2022
kon-angelo
kon-angelo approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 14, 2022
@kon-angelo kon-angelo added this to the v1.26 milestone Nov 14, 2022
@kon-angelo kon-angelo merged commit 779576d into gardener:master Nov 14, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dimitar-kostadinov @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot