controller-manager does not respect config.server.https

[timebertt]

How to categorize this issue?

/kind bug

What happened:

When configuring ControllerManagerConfiguration.server.https (

gardener/pkg/controllermanager/apis/config/v1alpha1/types.go

Lines 325 to 326 in dc4eb4b

	// HTTPS is the configuration for the HTTPS server.
	HTTPS HTTPSServer `json:"https"`

), it is simply ignored by gardener-controller-manager

gardener/cmd/gardener-controller-manager/app/gardener_controller_manager.go

Lines 290 to 297 in dc4eb4b

	go server.
	NewBuilder().
	WithBindAddress(g.Config.Server.HTTP.BindAddress).
	WithPort(g.Config.Server.HTTP.Port).
	WithHandler("/metrics", promhttp.Handler()).
	WithHandlerFunc("/healthz", healthz.HandlerFunc(healthManager)).
	Build().
	Start(ctx)

and no HTTPS handler is started using the provided configuration.

What you expected to happen:

controller-manager to respect the configuration options just like gardenlet:

gardener/cmd/gardenlet/app/gardenlet.go

Lines 425 to 454 in dc4eb4b

	// Start HTTPS server.
	if g.Config.Server.HTTPS.TLS == nil {
	g.Logger.Info("No TLS server certificates provided... self-generating them now...")
	_, _, tempDir, err := secrets.SelfGenerateTLSServerCertificate("gardenlet", []string{
	"gardenlet",
	fmt.Sprintf("gardenlet.%s", v1beta1constants.GardenNamespace),
	fmt.Sprintf("gardenlet.%s.svc", v1beta1constants.GardenNamespace),
	}, nil)
	if err != nil {
	return err
	}
	g.Config.Server.HTTPS.TLS = &config.TLSServer{
	ServerCertPath: filepath.Join(tempDir, secrets.DataKeyCertificate),
	ServerKeyPath: filepath.Join(tempDir, secrets.DataKeyPrivateKey),
	}
	g.Logger.Info("TLS server certificates successfully self-generated.")
	}
	go server.
	NewBuilder().
	WithBindAddress(g.Config.Server.HTTPS.BindAddress).
	WithPort(g.Config.Server.HTTPS.Port).
	WithTLS(g.Config.Server.HTTPS.TLS.ServerCertPath, g.Config.Server.HTTPS.TLS.ServerKeyPath).
	WithHandler("/metrics", promhttp.Handler()).
	WithHandlerFunc("/healthz", healthz.HandlerFunc(g.HealthManager)).
	Build().
	Start(ctx)

[timebertt]

depends on the decision in #2829

[gardener-ci-robot]

The Gardener project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed
  You can:
• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close

/lifecycle stale

[rfranzke]

/remove-lifecycle rotten

[gardener-ci-robot]

The Gardener project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close

/lifecycle stale

[timebertt]

/remove-lifecycle stale