-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller-manager] Introduce controller-runtime
manager and switch CloudProfile
controller
#6333
Conversation
1873923
to
a5ee693
Compare
pkg/controllermanager/controller/cloudprofile/reconciler_test.go
Outdated
Show resolved
Hide resolved
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I'm very excited about this one 🎉
pkg/controllermanager/controller/certificatesigningrequest/csr_autoapprove_control.go
Outdated
Show resolved
Hide resolved
pkg/controllermanager/controller/secretbinding/secretbinding.go
Outdated
Show resolved
Hide resolved
/uncc |
CloudProfile
controller
CloudProfile
controllerCloudProfile
controller
The configuration option wasn't effective, drop it instead of fixing it. Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com>
https was never working, ref gardener#4605 The config structure is similar to admission-controller now and fits to the manager.Options structure as well. Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com>
This will be used to create a standalone PlantClientMap for the plant controller with the client from the c-r manager.
I hope, I didn't miss anything during the rebase party. |
@timebertt: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, let's go!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CloudProfile
controllercontroller-runtime
manager in gardener-controller-manager
and switch CloudProfile
controller
controller-runtime
manager in gardener-controller-manager
and switch CloudProfile
controllercontroller-runtime
manager and switch CloudProfile
controller
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Introduce controller-runtime manager in controller-manager and refactor the first controller (
CloudProfile
) as an example.The reworked entrypoint (
app
package) and config API is supposed to serve as a template for reworking the others as well.Which issue(s) this PR fixes:
Part of #4251
Closes #4605
Special notes for your reviewer:
Partly co-authored by @rfranzke.
Release note: