Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize RESTMapper creation, remove DiscoveryConfiguration #2415

Merged
merged 1 commit into from Jun 8, 2020
Merged

Harmonize RESTMapper creation, remove DiscoveryConfiguration #2415

merged 1 commit into from Jun 8, 2020

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area quality
/kind cleanup
/priority normal

What this PR does / why we need it:
This PR removes the disk cached discovery clients in gardener-scheduler, gardener-controller-manager and gardenlet and makes use of the controller-runtime's dynamic RESTMapper.

Which issue(s) this PR fixes:
Part of #2414

Special notes for your reviewer:

Release note:

The `discovery` section has been removed completely from the `GardenletConfiguration`, `SchedulerConfiguration`, `ControllerManagerConfiguration` and the respective charts in `charts/gardener` as it is no longer needed. Please adapt your chart usages and/or component configurations accordingly.

@timebertt timebertt requested a review from a team as a code owner June 3, 2020 13:05
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up priority/normal labels Jun 3, 2020
@timebertt timebertt mentioned this pull request Jun 3, 2020
Closed
16 tasks
@timebertt timebertt mentioned this pull request Jun 4, 2020
Merged
@rfranzke
Copy link
Member

rfranzke commented Jun 5, 2020

/assign
/invite @timuthy

@rfranzke
Copy link
Member

rfranzke commented Jun 5, 2020

Screen Shot 2020-06-05 at 08 09 02

I like such PRs :)

rfranzke
rfranzke previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/client/kubernetes/client.go Outdated Show resolved Hide resolved
@timebertt timebertt requested a review from rfranzke June 5, 2020 06:25
@timuthy timuthy self-assigned this Jun 8, 2020
timuthy
timuthy approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy timuthy merged commit 58690b7 into gardener:master Jun 8, 2020
@timebertt timebertt deleted the enh/restmapper branch June 8, 2020 11:02
@timebertt timebertt mentioned this pull request Aug 18, 2020
Closed
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timuthy timuthy timuthy approved these changes

Assignees

@rfranzke rfranzke

@timuthy timuthy

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@timebertt @rfranzke @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot