Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Applier, ChartRenderer and ChartApplier creation #2417

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Jun 4, 2020

How to categorize this PR?

/area quality
/kind enhancement
/priority normal

What this PR does / why we need it:
This PR harmonizes/centralizes how Applier, ChartRenderer and ChartApplier instances are obtained in g/g.
It removes any seperate constructions of ChartRenderers and ChartAppliers in favor of two respective functions that were added to pkg/client/kubernetes.Interface to obtain such instances.
This is needed to ensure, that we use the same controller-runtime clients while applying Charts everywhere to be able to leverage the clients' caches (which is not possible, if we construct new clients, ChartAppliers and so on, wherever needed).

Which issue(s) this PR fixes:
Part of #2414

Special notes for your reviewer:
This PR also contains one commit from #2415, as it depends on it.
I opened this as a draft PR to collect early feedback and will rebase and drop the commit once #2415 has been merged.
/invite @gardener/gardener-maintainers

✅ Depends on #2415

Release note:

The `pkg/client/kubernetes.ApplierInterface` interface has been renamed to `Applier`. Please adapt your usages accordingly when revendoring.
You can now obtain a `ChartRenderer` and a `ChartApplier` by using the respective functions of the ClientSet interface (`pkg/client/kubernetes.Interface`). Please use the provided functions instead of constructing new `ChartRenderer`s and `ChartApplier`s wherever needed.

@timebertt
Copy link
Member Author

removed commit from #2415

/ready-for-review
/needs review

@gardener-robot gardener-robot marked this pull request as ready for review June 8, 2020 11:06
@gardener-robot gardener-robot requested a review from a team as a code owner June 8, 2020 11:06
rfranzke
rfranzke previously approved these changes Jun 8, 2020
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR... no comments from my side, other than:
/lgtm

Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff. Otherwise looks good.

pkg/chartrenderer/default.go Outdated Show resolved Hide resolved
pkg/client/kubernetes/applier.go Outdated Show resolved Hide resolved
pkg/client/kubernetes/applier.go Outdated Show resolved Hide resolved
pkg/client/kubernetes/applier.go Outdated Show resolved Hide resolved
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@plkokanov Command /lgtm is not available to you but only to a Maintainer.

@rfranzke rfranzke merged commit 4c8afe7 into gardener:master Jun 9, 2020
@timebertt timebertt deleted the enh/applier-renderer branch June 9, 2020 06:49
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants