-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use protobuf in gardener components #3467
Conversation
/assign |
/assign @ialidzhikov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, only one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
* Don't default content type in config APIs * Make content type optional in charts * Configure clients to use protobuf wherever possible * Enable protobuf also for seedmanagement * Correct typos * Improve gardenlet config defaults tests
* Don't default content type in config APIs * Make content type optional in charts * Configure clients to use protobuf wherever possible * Enable protobuf also for seedmanagement * Correct typos * Improve gardenlet config defaults tests
* Don't default content type in config APIs * Make content type optional in charts * Configure clients to use protobuf wherever possible * Enable protobuf also for seedmanagement * Correct typos * Improve gardenlet config defaults tests
How to categorize this PR?
/area performance cost networking
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR configures clients in all gardener components to use the protobuf content type wherever possible.
Earlier we used
application/json
everywhere (set in gardener helm charts, defaulted in component configs).Now, the content type fields are optional in the charts as well as the component configs and are not defaulted anymore.
If left empty, gardener will configure all clients that talk to k8s / gardener APIs using protobuf, for CRDs we still use
application/json
as they don't support protobuf.Which issue(s) this PR fixes:
Fixes #2836
Part of #3109
Special notes for your reviewer:
I think, I cut down json requests to the minimum amount that is possible ATM. There are still json requests in the following cases:
tokenreviews/subjectaccessreviews
to k-api via json as part of the delegating authn/authz mechanisms (not configurable in the API server library, IISIC)kube-system/extension-apiserver-authentication
cm using json, also not configurable/squash
Release note: