Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dashboards #4229

Merged
merged 2 commits into from Jun 22, 2021
Merged

Improve dashboards #4229

merged 2 commits into from Jun 22, 2021

Conversation

wyb1
Copy link
Contributor

@wyb1 wyb1 commented Jun 18, 2021

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:

Dashboards use UTC instead of browser time by default and dashboards will no longer auto refresh by default.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

/cc @dguendisch

Release note:

Dashboards use UTC instead of browser time by default

@wyb1 wyb1 requested a review from a team as a code owner June 18, 2021 08:32
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2021
dguendisch
dguendisch approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thank you very much!
(cc @dkistner)

vpnachev
vpnachev approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit 87a1572 into gardener:master Jun 22, 2021
@ialidzhikov ialidzhikov mentioned this pull request Jan 24, 2022
Merged
This was referenced Feb 21, 2022
Merged
Merged
@ialidzhikov ialidzhikov mentioned this pull request Mar 25, 2022
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@wyb1
Improve dashboards (gardener#4229)
5cd72a3 
* Use UTC instead of browser time in dashboards

* Remove auto refresh from dashboards
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@wyb1
Improve dashboards (gardener#4229)
c138161 
* Use UTC instead of browser time in dashboards

* Remove auto refresh from dashboards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@dguendisch dguendisch dguendisch approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wyb1 @vpnachev @dguendisch @timebertt @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot