Add prometheus for seed monitoring #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Looking forward to using it :) Probably it's a good idea to directly build this new component as a golang component instead of a helm chart. Otherwise, we will refactor it sooner or later (see #2754). |
|
@wyb1 You need rebase this pull request with latest master branch. Please check. |
|
/assign |
wyb1
force-pushed
the
seed-monitoring
branch
from
edfd3c0
to
fd9127b
Compare
gardener-robot
added
needs/review
kind/api-change
|
Rebased. Will work on refactoring this PR as a golang component. |
|
As discussed offline, let's not put effort into refactoring this PR into a golang component and proceed with it in the current state. At a later point, we rather want to evaluate whether and how we can/want to extract monitoring and logging components out of the gardener/gardener repository into dedicated repositories that can be developed, released and deployed individually like gardener extensions. |
timebertt
reviewed
Sep 7, 2021
vpnachev
reviewed
Sep 10, 2021
|
/author-action |
|
@wyb1 The pull request was assigned to you under |
wyb1
force-pushed
the
seed-monitoring
branch
from
fd9127b
to
2d759b8
Compare
- Add VPA for the prometheus - Add Prometheus as a datasource to grafana - Add documentation for prometheus instances - Add unit tests for new network policies Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
wyb1
force-pushed
the
seed-monitoring
branch
from
c80675f
to
27de1da
Compare
timebertt
approved these changes
Sep 15, 2021
rfranzke
approved these changes
Sep 15, 2021
|
/assign @vpnachev for review and milestone |
gardener-robot
added
area/monitoring
This was referenced Oct 11, 2021
istvanballok
added a commit
to istvanballok/gardener
that referenced
this pull request
Dec 10, 2021
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
rfranzke
pushed a commit
that referenced
this pull request
Dec 10, 2021
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See #4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
Add a new Prometheus that will monitor the components running in the extension-* and garden namespaces. All extensions will have cadvisor metrics monitored by default. If extensions are exposing custom metrics they will be scraped if the following annotations are added to the pods:
/cc @MartinWeindel
Which issue(s) this PR fixes:
Fixes #2946
Special notes for your reviewer:
In the long term this new Prometheus could eventually replace the aggregate prometheus. We will need some experience with how this Prometheus handles the load of the cadvisor metrics.
Release note: