Keep the namespace and pod labels #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
gardener-robot
added
area/monitoring
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
The "extensions" and "garden" scrape configuration scrapes the pods that are marked with an annotation in the garden and extension-.+ namespaces. See gardener#4560 for more details. Previously, only the pod labels were kept as metric labels, the pod name and the namespace were missing. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
The "extensions" and "garden" scrape configuration scrapes the pods that
are marked with an annotation in the garden and extension-.+ namespaces.
See #4560 for more details.
Previously, only the pod labels were kept as metric labels, the pod name
and the namespace were missing.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: