Switch controller-manager to logr (2) #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename reconcilers and queues a bit and add some doc strings to make it easier to understand what the controller does and how it works.
Done in a separate commit, otherwise diff is unreviewable.
Done in another separate commit, otherwise diff is unreviewable.
gardener-robot
added
area/dev-productivity
|
/assign |
76 tasks
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Switch controllerregistration controller to logr Rename reconcilers and queues a bit and add some doc strings to make it easier to understand what the controller does and how it works. * Rename files to reflect code structure Done in a separate commit, otherwise diff is unreviewable. * Rename files to reflect code structure (2) Done in another separate commit, otherwise diff is unreviewable. * Switch controllerdeployment controller to logr
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Switch controllerregistration controller to logr Rename reconcilers and queues a bit and add some doc strings to make it easier to understand what the controller does and how it works. * Rename files to reflect code structure Done in a separate commit, otherwise diff is unreviewable. * Rename files to reflect code structure (2) Done in another separate commit, otherwise diff is unreviewable. * Switch controllerdeployment controller to logr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area logging dev-productivity
/kind enhancement
What this PR does / why we need it:
Continuation of #5057
Migrate more controller-manager controllers:
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Use the commit view! The combined diff is not quite reviewable because of file renaming.
/squash
Release note: