Switch controller-manager to logr (3) #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with two cases that were not described yet: - only logging an object name instead of a full key - logging in combination with event recorders
gardener-robot
added
area/dev-productivity
rfranzke
reviewed
Jan 20, 2022
|
Thanks, @rfranzke. Nice catches :) |
76 tasks
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Extend logging guideline with two cases that were not described yet: - only logging an object name instead of a full key - logging in combination with event recorders * Switch event controller to logr * Switch exposureclass controller to logr * Switch plant controller to logr * Switch managedseedset controller to logr * Address review comments
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Extend logging guideline with two cases that were not described yet: - only logging an object name instead of a full key - logging in combination with event recorders * Switch event controller to logr * Switch exposureclass controller to logr * Switch plant controller to logr * Switch managedseedset controller to logr * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area logging dev-productivity
/kind enhancement
What this PR does / why we need it:
Continuation of #5268
Migrate more controller-manager controllers:
Also extend the logging guideline with some new learnings (first commit, to make the other commits more understandable).
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
/squash
Release note: