Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy client certificate for Prometheus #6049

Merged
merged 1 commit into from
May 30, 2022

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area security
/kind enhancement

What this PR does / why we need it:
This PR drops the (deprecated) legacy client certificate for Prometheus. It was deprecated as part of #5008, however kept for a while to give extension developers time to adapt their scrape configurations.

Which issue(s) this PR fixes:
Part of #4661
Part of #4878

Release note:

The deprecated client certificate for Prometheus has been dropped. Extensions still relying on it must now adapt their scrape configurations according to the [documentation](https://github.com/gardener/gardener/blob/master/docs/extensions/logging-and-monitoring.md#extensions-monitoring-integration).

@gardener-prow gardener-prow bot added area/security Security related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 30, 2022
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2022
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@rfranzke
Copy link
Member Author

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@gardener-prow gardener-prow bot merged commit 4ca1a80 into gardener:master May 30, 2022
@rfranzke rfranzke deleted the drop/prom-client branch May 30, 2022 17:28
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security Security related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants