Refactor reserve-excess-capacity Helm chart into Golang component
#6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
20 tasks
35 tasks
|
/lgtm |
ary1992
reviewed
Jun 21, 2022
ialidzhikov
reviewed
Jun 21, 2022
There was a problem hiding this comment.
1 inline question.
I was also wondering what is the difference between the reserve-excess-capacity that is deployed as part of the Seed reconciliation and the following extension https://github.com/gardener/reserve-excess-capacity?
|
/assign @ialidzhikov @ary1992 @shafeeqes @kris94 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
timebertt
added a commit
to timebertt/gardener
that referenced
this pull request
Jun 24, 2022
This is already done by the seedsystem component when removing the relevant object from the ManagedResource secret. Follow-up to gardener#6135
timebertt
added a commit
to timebertt/gardener
that referenced
this pull request
Jun 28, 2022
This is already done by the seedsystem component when removing the relevant object from the ManagedResource secret. Follow-up to gardener#6135
gardener-prow bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
…ardenlet (#6186) * Document well-known PriorityClasses * Introduce constants for well-known PriorityClass names Constant names include their purpose as well to make misuse less likely. * Manage well-known Seed PriorityClasses in seedsystem * Deprecated gardener-shoot-controlplane and manage in seedsystem * Manage well-known Shoot PriorityClasses in shootsystem * Drop DeleteReserveExcessCapacity This is already done by the seedsystem component when removing the relevant object from the ManagedResource secret. Follow-up to #6135 * Address suggestions
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…ardener#6135) * Add basic template of new `seedsystem` component * Integrate `seedsystem` component into seed reconciliation/deletion flows * Refactor `PriorityClass` template to Golang object * Refactor `Deployment` template to Golang object * Drop no longer required code * Consider `seedsystem` components in seed health check * Address PR review feedback
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…ardenlet (gardener#6186) * Document well-known PriorityClasses * Introduce constants for well-known PriorityClass names Constant names include their purpose as well to make misuse less likely. * Manage well-known Seed PriorityClasses in seedsystem * Deprecated gardener-shoot-controlplane and manage in seedsystem * Manage well-known Shoot PriorityClasses in shootsystem * Drop DeleteReserveExcessCapacity This is already done by the seedsystem component when removing the relevant object from the ManagedResource secret. Follow-up to gardener#6135 * Address suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity quality robustness
/kind technical-debt test enhancement
/topology seed
/platform all
/exp intermediate
/merge squash
What this PR does / why we need it:
This PR refactors the deployment for the
reserve-excess-capacityHelm resources. It adopts the component concept. Consequently, it eliminates the Helm resources and adds unit tests, instead. This improves several aspects and the overall code quality.Which issue(s) this PR fixes:
Part of #2754
Release note: