-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch controller-manager to logr (5) #6253
Conversation
Also, switch reference reconciler to client.Client
@timebertt: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area logging dev-productivity
/kind enhancement
What this PR does / why we need it:
Continuation of #5488
Migrate controller-manager shoot controller to logr.
This was the last one in controller-manager, meaning it is fully migrated now.
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
We have to keep instantiating
logger.Logger
in controller-manager for now, as there are a few minor usages in helper funcs shared with gardenlet.We can drop this, once they have been switched as well.
Release note: