Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch controller-manager to logr (5) #6253

Merged
merged 10 commits into from
Jul 4, 2022

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area logging dev-productivity
/kind enhancement

What this PR does / why we need it:

Continuation of #5488
Migrate controller-manager shoot controller to logr.
This was the last one in controller-manager, meaning it is fully migrated now.

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:

We have to keep instantiating logger.Logger in controller-manager for now, as there are a few minor usages in helper funcs shared with gardenlet.
We can drop this, once they have been switched as well.

Release note:

NONE

@gardener-prow gardener-prow bot added area/logging Logging related area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels Jul 4, 2022
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 4, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 4, 2022

@timebertt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 242d705 link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfranzke
Copy link
Member

rfranzke commented Jul 4, 2022

/assign

@rfranzke
Copy link
Member

rfranzke commented Jul 4, 2022

/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2022
@gardener-prow gardener-prow bot merged commit 9cfe154 into gardener:master Jul 4, 2022
@timebertt timebertt deleted the refactor/gcm-logr-5 branch July 4, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/logging Logging related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants