Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch controller-manager to logr (4) #5488

Merged
merged 9 commits into from
Feb 28, 2022

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area logging dev-productivity
/kind enhancement

What this PR does / why we need it:

Continuation of #5290
Migrate more controller-manager controllers:

  • project controller
  • quota controller
  • secretbinding controller
  • seed controller

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:

Only the shoot controller and some cleanups left to finish migrating gcm to logr.

/squash

Release note:

NONE

@timebertt timebertt requested a review from a team as a code owner February 24, 2022 16:25
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/logging Logging related kind/enhancement Enhancement, improvement, extension merge/squash size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2022
@rfranzke
Copy link
Member

/assign

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 2594342 into gardener:master Feb 28, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
* Switch project controller to logr

* Switch project stale controller to logr

* Switch project activity controller to logr

* Switch quota controller to logr

* Switch secretbinding controller to logr

* Switch seed controller to logr

* Switch seed secrets reconciler to logr

* Switch seed lifecycle reconciler to logr

* Switch seed backupbucket reconciler to logr
@timebertt timebertt deleted the refactor/gcm-logr-4 branch June 30, 2022 06:24
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* Switch project controller to logr

* Switch project stale controller to logr

* Switch project activity controller to logr

* Switch quota controller to logr

* Switch secretbinding controller to logr

* Switch seed controller to logr

* Switch seed secrets reconciler to logr

* Switch seed lifecycle reconciler to logr

* Switch seed backupbucket reconciler to logr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) area/logging Logging related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants