Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch gardenlet to logr (7) #6278

Merged
merged 12 commits into from
Jul 11, 2022
Merged

Switch gardenlet to logr (7) #6278

merged 12 commits into from
Jul 11, 2022

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jul 6, 2022

How to categorize this PR?

/area logging dev-productivity
/kind enhancement

What this PR does / why we need it:
Migrate gardenlet's Seed controller to logr.

Which issue(s) this PR fixes:
Part of #4251

Release note:

NONE

@gardener-prow gardener-prow bot added the area/logging Logging related label Jul 6, 2022
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 6, 2022
@rfranzke rfranzke mentioned this pull request Jul 6, 2022
Closed
76 tasks
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 6, 2022
rfranzke added a commit to rfranzke/gardener that referenced this pull request Jul 6, 2022
@rfranzke
-------- empty separator commit --------
3f2fe98 
End of commits of gardener#6278
@rfranzke rfranzke mentioned this pull request Jul 6, 2022
Merged
plkokanov
plkokanov requested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and easy to go through PR :)
I just have a couple of suggestion and questions.

pkg/gardenlet/controller/seed/seed.go Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed_control.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed_control.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed_control.go Outdated Show resolved Hide resolved
pkg/operation/garden/garden.go Outdated Show resolved Hide resolved
pkg/operation/garden/garden.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/kubernetes.go Show resolved Hide resolved
ary1992
ary1992 reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@ary1992 ary1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the well-organized PR.

pkg/gardenlet/controller/seed/seed_care_control.go Show resolved Hide resolved
pkg/operation/seed/seed.go Show resolved Hide resolved
pkg/operation/seed/seed.go Show resolved Hide resolved
@rfranzke rfranzke requested a review from plkokanov July 11, 2022 08:34
timebertt
timebertt requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, otherwise lgtm

pkg/controllermanager/controller/factory.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/factory.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/factory.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed_control.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed_control.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
@timebertt timebertt added this to the v1.51 milestone Jul 11, 2022
@timebertt timebertt self-assigned this Jul 11, 2022
@rfranzke rfranzke requested a review from timebertt July 11, 2022 17:40
@rfranzke
Copy link
Member Author

/retest

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 11, 2022 •
edited
Loading

@rfranzke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 3bf9242 link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rfranzke added a commit to rfranzke/gardener that referenced this pull request Jul 11, 2022
@rfranzke
-------- empty separator commit --------
4e720a5 
End of commits of gardener#6278
timebertt
timebertt approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2022
@gardener-prow gardener-prow bot merged commit eef6129 into gardener:master Jul 11, 2022
@rfranzke rfranzke deleted the refactor/gardenlet-logs-7 branch July 12, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ary1992 ary1992 ary1992 left review comments

@timebertt timebertt timebertt approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@plkokanov plkokanov Awaiting requested review from plkokanov

Assignees

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/logging Logging related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfranzke @ary1992 @plkokanov @timebertt