-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch gardenlet
to logr
(8)
#6282
Switch gardenlet
to logr
(8)
#6282
Conversation
Skipping CI for Draft Pull Request. |
/test all |
af3b19d
to
394e69e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Quite the huge PR, but I made it through 😄
Just a few nits
394e69e
to
c07d4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this lgtm
c07d4b7
to
98d2589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-gardener-e2e-kind |
How to categorize this PR?
/area logging dev-productivity
/kind enhancement
What this PR does / why we need it:
Migrate
gardenlet
'sShoot
controller tologr
.Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer(s):
Depends on Switchgardenlet
tologr
(4) #6265, hence it's in draft state until this PR is merged.Depends on Switchgardenlet
tologr
(7) #6278, hence it's in draft state until this PR is merged.Release note: